Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: extensions/renderer/user_script_injector.cc

Issue 972863002: Revert of Refactoring: de-couple Extensions from "script injection System" [render side]:2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_1
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/extension_injection_host.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/user_script_injector.h" 5 #include "extensions/renderer/user_script_injector.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "content/public/common/url_constants.h" 10 #include "content/public/common/url_constants.h"
11 #include "content/public/renderer/render_view.h"
12 #include "extensions/common/extension.h" 11 #include "extensions/common/extension.h"
13 #include "extensions/common/permissions/permissions_data.h" 12 #include "extensions/common/permissions/permissions_data.h"
14 #include "extensions/renderer/injection_host.h" 13 #include "extensions/renderer/injection_host.h"
15 #include "extensions/renderer/script_context.h" 14 #include "extensions/renderer/script_context.h"
16 #include "extensions/renderer/scripts_run_info.h" 15 #include "extensions/renderer/scripts_run_info.h"
17 #include "grit/extensions_renderer_resources.h" 16 #include "grit/extensions_renderer_resources.h"
18 #include "third_party/WebKit/public/web/WebDocument.h" 17 #include "third_party/WebKit/public/web/WebDocument.h"
19 #include "third_party/WebKit/public/web/WebFrame.h" 18 #include "third_party/WebKit/public/web/WebFrame.h"
20 #include "third_party/WebKit/public/web/WebScriptSource.h" 19 #include "third_party/WebKit/public/web/WebScriptSource.h"
21 #include "ui/base/resource/resource_bundle.h" 20 #include "ui/base/resource/resource_bundle.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 UserScript::RunLocation run_location) const { 120 UserScript::RunLocation run_location) const {
122 return run_location == UserScript::DOCUMENT_START && 121 return run_location == UserScript::DOCUMENT_START &&
123 !script_->css_scripts().empty(); 122 !script_->css_scripts().empty();
124 } 123 }
125 124
126 PermissionsData::AccessType UserScriptInjector::CanExecuteOnFrame( 125 PermissionsData::AccessType UserScriptInjector::CanExecuteOnFrame(
127 const InjectionHost* injection_host, 126 const InjectionHost* injection_host,
128 blink::WebFrame* web_frame, 127 blink::WebFrame* web_frame,
129 int tab_id, 128 int tab_id,
130 const GURL& top_url) const { 129 const GURL& top_url) const {
130 // If we don't have a tab id, we have no UI surface to ask for user consent.
131 // For now, we treat this as an automatic allow.
132 if (tab_id == -1)
133 return PermissionsData::ACCESS_ALLOWED;
134
131 GURL effective_document_url = ScriptContext::GetEffectiveDocumentURL( 135 GURL effective_document_url = ScriptContext::GetEffectiveDocumentURL(
132 web_frame, web_frame->document().url(), script_->match_about_blank()); 136 web_frame, web_frame->document().url(), script_->match_about_blank());
133 PermissionsData::AccessType can_execute = injection_host->CanExecuteOnFrame( 137 return injection_host->CanExecuteOnFrame(
134 effective_document_url, top_url, tab_id, is_declarative_); 138 effective_document_url, top_url, tab_id, is_declarative_);
135
136 if (script_->consumer_instance_type() !=
137 UserScript::ConsumerInstanceType::WEBVIEW ||
138 can_execute == PermissionsData::ACCESS_DENIED)
139 return can_execute;
140
141 int routing_id = content::RenderView::FromWebView(web_frame->top()->view())
142 ->GetRoutingID();
143 return script_->routing_info().render_view_id == routing_id
144 ? PermissionsData::ACCESS_ALLOWED
145 : PermissionsData::ACCESS_DENIED;
146 } 139 }
147 140
148 std::vector<blink::WebScriptSource> UserScriptInjector::GetJsSources( 141 std::vector<blink::WebScriptSource> UserScriptInjector::GetJsSources(
149 UserScript::RunLocation run_location) const { 142 UserScript::RunLocation run_location) const {
150 DCHECK_EQ(script_->run_location(), run_location); 143 DCHECK_EQ(script_->run_location(), run_location);
151 144
152 std::vector<blink::WebScriptSource> sources; 145 std::vector<blink::WebScriptSource> sources;
153 const UserScript::FileList& js_scripts = script_->js_scripts(); 146 const UserScript::FileList& js_scripts = script_->js_scripts();
154 bool is_standalone_or_emulate_greasemonkey = 147 bool is_standalone_or_emulate_greasemonkey =
155 script_->is_standalone() || script_->emulate_greasemonkey(); 148 script_->is_standalone() || script_->emulate_greasemonkey();
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 } 202 }
210 203
211 if (ShouldInjectCss(run_location)) 204 if (ShouldInjectCss(run_location))
212 scripts_run_info->num_css += script_->css_scripts().size(); 205 scripts_run_info->num_css += script_->css_scripts().size();
213 } 206 }
214 207
215 void UserScriptInjector::OnWillNotInject(InjectFailureReason reason) { 208 void UserScriptInjector::OnWillNotInject(InjectFailureReason reason) {
216 } 209 }
217 210
218 } // namespace extensions 211 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/extension_injection_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698