Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 972463002: app_list: Elevate the verbosity level to 1. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, danakj, M-A Ruel, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

app_list: Elevate the verbosity level to 1. This elevates it from 4 or 5 depending if it is a normal file or unit test file to 1 for everything. Used the following command line to lint the files: $ for in $(g ls-files ui/app_list/ | grep -E '.*\.(cc|h)$' | grep -v cocoa); do cpplint.py --verbose=1 $f; done BUG=None TEST=see above R=tapted@chromium.org Committed: https://crrev.com/5d9e90918f4215d63eb9706df76b648e33b68c04 Cr-Commit-Position: refs/heads/master@{#318745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/app_list/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_result_page_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/start_page_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL!
5 years, 9 months ago (2015-02-28 20:46:35 UTC) #1
tapted
lgtm
5 years, 9 months ago (2015-03-01 22:42:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972463002/1
5 years, 9 months ago (2015-03-02 19:40:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 21:01:42 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 21:02:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d9e90918f4215d63eb9706df76b648e33b68c04
Cr-Commit-Position: refs/heads/master@{#318745}

Powered by Google App Engine
This is Rietveld 408576698