Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: ui/app_list/PRESUBMIT.py

Issue 972463002: app_list: Elevate the verbosity level to 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/app_list/views/search_result_page_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for app_list. 5 """Presubmit script for app_list.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 INCLUDE_CPP_FILES_ONLY = ( 11 INCLUDE_CPP_FILES_ONLY = (
12 r'.*\.(cc|h)$', 12 r'.*\.(cc|h)$',
13 ) 13 )
14 14
15 EXCLUDE = ( 15 EXCLUDE = (
16 # Objective C confuses everything. 16 # Objective C confuses everything.
17 r'.*/cocoa/.*', 17 r'.*/cocoa/.*',
18 ) 18 )
19 19
20 def CheckChangeLintsClean(input_api, output_api): 20 def CheckChangeLintsClean(input_api, output_api):
21 """Makes sure that the ui/app_list/ code is cpplint clean.""" 21 """Makes sure that the ui/app_list/ code is cpplint clean."""
22 black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDE 22 black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDE
23 sources = lambda x: input_api.FilterSourceFile( 23 sources = lambda x: input_api.FilterSourceFile(
24 x, white_list = INCLUDE_CPP_FILES_ONLY, black_list = black_list) 24 x, white_list = INCLUDE_CPP_FILES_ONLY, black_list = black_list)
25 return input_api.canned_checks.CheckChangeLintsClean( 25 return input_api.canned_checks.CheckChangeLintsClean(
26 input_api, output_api, sources, []) 26 input_api, output_api, sources, lint_filters=[], verbose_level=1)
27 27
28 def CheckChangeOnUpload(input_api, output_api): 28 def CheckChangeOnUpload(input_api, output_api):
29 results = [] 29 results = []
30 results += CheckChangeLintsClean(input_api, output_api) 30 results += CheckChangeLintsClean(input_api, output_api)
31 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) 31 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
32 return results 32 return results
OLDNEW
« no previous file with comments | « no previous file | ui/app_list/views/search_result_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698