Chromium Code Reviews
Help | Chromium Project | Sign in
(10)

Issue 9724038: DevTools: convert about:workers into about:inspect (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by pfeldman
Modified:
2 years, 1 month ago
CC:
chromium-reviews_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, arv, jam, pam+watch_chromium.org
Visibility:
Public.

Description

DevTools: convert about:workers into about:inspect

BUG=118915
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127931

Patch Set 1 #

Total comments: 3

Patch Set 2 : Test fixed, comments addressed. #

Total comments: 28

Patch Set 3 : Review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+683 lines, -532 lines) Lint Patch
M chrome/browser/browser_about_handler.cc View 2 chunks +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/browser_resources.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/inspect/inspect.css View 1 2 1 chunk +37 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/inspect/inspect.html View 1 2 1 chunk +36 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/inspect/inspect.js View 1 2 1 chunk +133 lines, -0 lines 0 comments ? errors Download
D chrome/browser/resources/workers/index.html View 1 chunk +0 lines, -36 lines 0 comments ? errors Download
D chrome/browser/resources/workers/workers.js View 1 chunk +0 lines, -90 lines 0 comments ? errors Download
D chrome/browser/resources/workers_resources.grd View 1 chunk +0 lines, -24 lines 0 comments ? errors Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 3 chunks +3 lines, -3 lines 0 comments 1 errors Download
A chrome/browser/ui/webui/inspect_ui.h View 1 2 1 chunk +38 lines, -0 lines 0 comments 1 errors Download
A chrome/browser/ui/webui/inspect_ui.cc View 1 2 1 chunk +411 lines, -0 lines 0 comments 6 errors Download
A + chrome/browser/ui/webui/inspect_ui_browsertest.cc View 1 2 3 chunks +14 lines, -8 lines 0 comments ? errors Download
D chrome/browser/ui/webui/workers_ui.h View 1 chunk +0 lines, -24 lines 0 comments 0 errors Download
D chrome/browser/ui/webui/workers_ui.cc View 1 chunk +0 lines, -271 lines 0 comments 0 errors Download
D chrome/browser/ui/webui/workers_ui_browsertest.cc View 1 chunk +0 lines, -58 lines 0 comments 0 errors Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M chrome/chrome_repack_resources.gypi View 1 chunk +0 lines, -1 line 0 comments ? errors Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -7 lines 0 comments ? errors Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -1 line 0 comments ? errors Download
M chrome/common/url_constants.h View 1 2 3 chunks +2 lines, -1 line 0 comments ? errors Download
M chrome/common/url_constants.cc View 1 2 3 chunks +2 lines, -1 line 0 comments ? errors Download
M content/browser/debugger/devtools_http_handler_impl.cc View 1 chunk +0 lines, -1 line 0 comments ? errors Download
M tools/gritsettings/resource_ids View 1 chunk +0 lines, -3 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 9
pfeldman
2 years, 1 month ago #1
apavlov
https://chromiumcodereview.appspot.com/9724038/diff/1/chrome/browser/resources/inspect/inspect.html File chrome/browser/resources/inspect/inspect.html (right): https://chromiumcodereview.appspot.com/9724038/diff/1/chrome/browser/resources/inspect/inspect.html#newcode30 chrome/browser/resources/inspect/inspect.html:30: background-color: rgb(235, 239, 249); Is there any consistent color ...
2 years, 1 month ago #2
pfeldman
On 2012/03/19 16:16:47, apavlov wrote: > https://chromiumcodereview.appspot.com/9724038/diff/1/chrome/browser/resources/inspect/inspect.html > File chrome/browser/resources/inspect/inspect.html (right): > > https://chromiumcodereview.appspot.com/9724038/diff/1/chrome/browser/resources/inspect/inspect.html#newcode30 > ...
2 years, 1 month ago #3
yurys
lgtm http://codereview.chromium.org/9724038/diff/3001/chrome/browser/resources/inspect/inspect.js File chrome/browser/resources/inspect/inspect.js (right): http://codereview.chromium.org/9724038/diff/3001/chrome/browser/resources/inspect/inspect.js#newcode1 chrome/browser/resources/inspect/inspect.js:1: // Copyright (c) 2011 The Chromium Authors. All ...
2 years, 1 month ago #4
pfeldman
http://codereview.chromium.org/9724038/diff/3001/chrome/browser/resources/inspect/inspect.js File chrome/browser/resources/inspect/inspect.js (right): http://codereview.chromium.org/9724038/diff/3001/chrome/browser/resources/inspect/inspect.js#newcode1 chrome/browser/resources/inspect/inspect.js:1: // Copyright (c) 2011 The Chromium Authors. All rights ...
2 years, 1 month ago #5
pfeldman
Seeking for owners' stamp. This change renames files under chrome/browser/ui/webui and chrome/browser/resources.
2 years, 1 month ago #6
csilv
http://codereview.chromium.org/9724038/diff/3001/chrome/browser/resources/inspect/inspect.html File chrome/browser/resources/inspect/inspect.html (right): http://codereview.chromium.org/9724038/diff/3001/chrome/browser/resources/inspect/inspect.html#newcode12 chrome/browser/resources/inspect/inspect.html:12: <style> Please move CSS into a new file, inspect.css ...
2 years, 1 month ago #7
pfeldman
Thanks for the review! http://codereview.chromium.org/9724038/diff/3001/chrome/browser/resources/inspect/inspect.html File chrome/browser/resources/inspect/inspect.html (right): http://codereview.chromium.org/9724038/diff/3001/chrome/browser/resources/inspect/inspect.html#newcode12 chrome/browser/resources/inspect/inspect.html:12: <style> On 2012/03/20 18:22:02, csilv ...
2 years, 1 month ago #8
csilv
2 years, 1 month ago #9
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6