Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: components/guest_view/common/guest_view_messages.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome
Patch Set: Move iframe*guestview to components/ Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/common/guest_view_messages.h
diff --git a/components/guest_view/common/guest_view_messages.h b/components/guest_view/common/guest_view_messages.h
index bc0061d650020eb990c7fdd75201ecf5c7c03b28..e70e0d7384897148d05d68de5375c444f5954aeb 100644
--- a/components/guest_view/common/guest_view_messages.h
+++ b/components/guest_view/common/guest_view_messages.h
@@ -12,6 +12,10 @@
// Messages sent from the browser to the renderer.
+// Tells the embedder that a guest has been attached in --site-per-process mode.
+IPC_MESSAGE_CONTROL1(GuestViewMsg_AttachToEmbedderFrame_ACK,
+ int /* element_instance_id */)
+
// Once a RenderView proxy has been created for the guest in the embedder render
// process, this IPC informs the embedder of the proxy's routing ID.
IPC_MESSAGE_CONTROL2(GuestViewMsg_GuestAttached,
@@ -34,6 +38,16 @@ IPC_MESSAGE_CONTROL3(GuestViewHostMsg_AttachGuest,
int /* guest_instance_id */,
base::DictionaryValue /* attach_params */)
+// We have a RenderFrame with routing id of |embedder_local_frame_routing_id|.
+// We want this local frame to be replaced with a remote frame that points
+// to a <webview>. This message will attach the local frame to the <webview>
Fady Samuel 2015/06/23 14:33:00 nit: avoid references to <webview>.
lazyboy 2015/06/23 23:00:00 Done.
+// guest. The <webview> is identified by its ID: |guest_instance_id|.
+IPC_MESSAGE_CONTROL4(GuestViewHostMsg_AttachToEmbedderFrame,
+ int /* embedder_local_frame_routing_id */,
+ int /* element_instance_id */,
+ int /* guest_instance_id */,
+ base::DictionaryValue /* params */)
+
// Sent by the renderer when a GuestView (identified by |view_instance_id|) has
// been created in JavaScript.
IPC_MESSAGE_CONTROL2(GuestViewHostMsg_ViewCreated,

Powered by Google App Engine
This is Rietveld 408576698