content/browser/browser_plugin/browser_plugin_guest.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: Move iframe*guestview to components/ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/guest_view/common/guest_view_messages.h ('K') | « components/guest_view/renderer/iframe_guest_view_request.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/browser/frame_host/cross_process_frame_connector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index 438fc1694e1f03694d4955aef3c73eab21e33f81..4cd91aba5fa960c7b13e53e348fe7ee4d8a43e65 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -79,6 +79,9 @@ struct DropData;

// A BrowserPluginGuest can also create a new unattached guest via

// CreateNewWindow. The newly created guest will live in the same partition,

// which means it can share storage and can script this guest.

+//

+// Note: in --site-per-process, all IPCs sent out from this class will be

+// dropped on the floor since we don't have a BrowserPlugin.

class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,

Fady Samuel 2015/06/23 14:33:01 Could we refactor this then? GuestHostImpl + Gues

lazyboy 2015/06/23 23:00:00 I'd like to do that in a follow up CL.

public WebContentsObserver {

public: