components/guest_view/renderer/guest_view_container.cc - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/renderer/guest_view_container.cc

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: address comments from nasko@ + git cl format Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/guest_view/browser/guest_view_base.cc ('K') | « components/guest_view/renderer/guest_view_container.h ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | content/browser/browser_plugin/browser_plugin_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/renderer/guest_view_container.cc

diff --git a/components/guest_view/renderer/guest_view_container.cc b/components/guest_view/renderer/guest_view_container.cc

index d404c56f3a1536ae2b62097abd0eb82bafea90e4..5368ea3f0a1b49cc084f5e873e3653f9300acd07 100644

--- a/components/guest_view/renderer/guest_view_container.cc

+++ b/components/guest_view/renderer/guest_view_container.cc

@@ -47,9 +47,9 @@ void GuestViewContainer::RenderFrameLifetimeObserver::OnDestruct() {

}

GuestViewContainer::GuestViewContainer(content::RenderFrame* render_frame)

- : element_instance_id_(guest_view::kInstanceIDNone),

+ : ready_(false),

+ element_instance_id_(guest_view::kInstanceIDNone),

render_frame_(render_frame),

- ready_(false),

in_destruction_(false),

weak_ptr_factory_(this) {

render_frame_lifetime_observer_.reset(