Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: components/guest_view/renderer/guest_view_container.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome
Patch Set: address comments from nasko@ + git cl format Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/renderer/guest_view_container.h
diff --git a/components/guest_view/renderer/guest_view_container.h b/components/guest_view/renderer/guest_view_container.h
index 61c95fa17e49f6f0a647fe147af0aa88e1856360..5257807990a86555a3de894e24486c5b66d3ced4 100644
--- a/components/guest_view/renderer/guest_view_container.h
+++ b/components/guest_view/renderer/guest_view_container.h
@@ -52,9 +52,16 @@ class GuestViewContainer : public content::BrowserPluginDelegate {
// Note that this should be called exactly once.
virtual void OnDestroy(bool embedder_frame_destroyed) {}
+ // BrowserPluginGuestDelegate public implementation.
+ void SetElementInstanceID(int element_instance_id) final;
+
protected:
~GuestViewContainer() override;
+ bool ready_;
+
+ void OnHandleCallback(const IPC::Message& message);
+
private:
class RenderFrameLifetimeObserver;
friend class RenderFrameLifetimeObserver;
@@ -65,11 +72,8 @@ class GuestViewContainer : public content::BrowserPluginDelegate {
void PerformPendingRequest();
void HandlePendingResponseCallback(const IPC::Message& message);
- void OnHandleCallback(const IPC::Message& message);
-
// BrowserPluginDelegate implementation.
void Ready() final;
- void SetElementInstanceID(int element_instance_id) final;
void DidDestroyElement() final;
base::WeakPtr<BrowserPluginDelegate> GetWeakPtr() final;
@@ -77,7 +81,6 @@ class GuestViewContainer : public content::BrowserPluginDelegate {
content::RenderFrame* render_frame_;
scoped_ptr<RenderFrameLifetimeObserver> render_frame_lifetime_observer_;
- bool ready_;
bool in_destruction_;
std::deque<linked_ptr<GuestViewRequest> > pending_requests_;

Powered by Google App Engine
This is Rietveld 408576698