extensions/browser/guest_view/guest_view_manager.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_manager.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: some review comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.cc ('K') | « extensions/browser/guest_view/guest_view_base.cc ('k') | extensions/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_manager.h

diff --git a/extensions/browser/guest_view/guest_view_manager.h b/extensions/browser/guest_view/guest_view_manager.h

index 934c46747dd4656b813caf6118ed1df0fbfac3d9..3047f3f3fa989e944b5c25418d69e4d5fef74ab7 100644

--- a/extensions/browser/guest_view/guest_view_manager.h

+++ b/extensions/browser/guest_view/guest_view_manager.h

@@ -62,6 +62,10 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

int guest_instance_id,

const base::DictionaryValue& attach_params);

+ // Relax GetGuestByInstanceID for now, so we can wildly access a guest by

+ // its guest_instance_id.

+ content::WebContents* GetGuestByInstanceIDHack(int guest_instance_id);

// Removes the association between |element_instance_id| and a guest instance

// ID if one exists.

void DetachGuest(GuestViewBase* guest);