extensions/browser/guest_view/guest_view_manager.cc - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_manager.cc

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: some review comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.cc ('K') | « extensions/browser/guest_view/guest_view_manager.h ('k') | extensions/browser/guest_view/guest_view_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_manager.cc

diff --git a/extensions/browser/guest_view/guest_view_manager.cc b/extensions/browser/guest_view/guest_view_manager.cc

index b7ddae913cb8c7fbf2a050471b3d5b70b9b56817..e6998c69310fc2d6c1427209aa733aa988b8444f 100644

--- a/extensions/browser/guest_view/guest_view_manager.cc

+++ b/extensions/browser/guest_view/guest_view_manager.cc

@@ -71,6 +71,11 @@ content::WebContents* GuestViewManager::GetGuestByInstanceIDSafely(

return GetGuestByInstanceID(guest_instance_id);

}

+content::WebContents* GuestViewManager::GetGuestByInstanceIDHack(

+ int guest_instance_id) {

+ return GetGuestByInstanceID(guest_instance_id);

void GuestViewManager::AttachGuest(int embedder_process_id,

int element_instance_id,

int guest_instance_id,