Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 972193003: Fix for MIME handler bug. (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for MIME handler bug. The bug resulted from a previous bugfix (https://codereview.chromium.org/939443002/) that added a conversion from logical to physical units to fix a similar sizing bug with other guestviews. However, MIME handler guests never use logical pixels, so this conversion broke their sizing when they are created in a zoomed embedder. This patch adds a more robust method of checking whether sizes are provided in logical or physical units, and all cases are handled appropriately. BUG=462194 Committed: https://crrev.com/18f5a136e4ab830a3303c6a6f1d87c7f34eb7fd9 Cr-Commit-Position: refs/heads/master@{#318948}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M extensions/browser/api/guest_view/guest_view_internal_api.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 1 chunk +15 lines, -3 lines 0 comments Download
M extensions/common/guest_view/guest_view_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/guest_view/guest_view_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
paulmeyer
+fsamuel@
5 years, 9 months ago (2015-03-03 17:46:46 UTC) #2
Fady Samuel
https://codereview.chromium.org/972193003/diff/1/extensions/browser/guest_view/guest_view_base.cc File extensions/browser/guest_view/guest_view_base.cc (right): https://codereview.chromium.org/972193003/diff/1/extensions/browser/guest_view/guest_view_base.cc#newcode761 extensions/browser/guest_view/guest_view_base.cc:761: if (params.HasKey(guestview::kElementSizeIsLogical)) { This check seems unnecessary. Just call ...
5 years, 9 months ago (2015-03-03 17:50:58 UTC) #3
paulmeyer
ptal.
5 years, 9 months ago (2015-03-03 20:35:55 UTC) #4
paulmeyer
https://codereview.chromium.org/972193003/diff/1/extensions/browser/guest_view/guest_view_base.cc File extensions/browser/guest_view/guest_view_base.cc (right): https://codereview.chromium.org/972193003/diff/1/extensions/browser/guest_view/guest_view_base.cc#newcode761 extensions/browser/guest_view/guest_view_base.cc:761: if (params.HasKey(guestview::kElementSizeIsLogical)) { On 2015/03/03 17:50:58, Fady Samuel wrote: ...
5 years, 9 months ago (2015-03-03 20:36:23 UTC) #5
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-03 20:57:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972193003/20001
5 years, 9 months ago (2015-03-03 20:59:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 21:56:31 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 21:56:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18f5a136e4ab830a3303c6a6f1d87c7f34eb7fd9
Cr-Commit-Position: refs/heads/master@{#318948}

Powered by Google App Engine
This is Rietveld 408576698