Fix for MIME handler bug.

extensions/browser/guest_view/guest_view_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/guest_view_base.h"
 
 #include "base/lazy_instance.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/ui/zoom/page_zoom.h"
 #include "components/ui/zoom/zoom_controller.h"
@@ skipping 736 matching lines @@
   int min_width = 0;
   params.GetInteger(guestview::kAttributeMinHeight, &min_height);
   params.GetInteger(guestview::kAttributeMinWidth, &min_width);
 
   // Set the normal size to the element size so that the guestview will fit the
   // element initially if autosize is disabled.
   double element_height = 0.0;
   double element_width = 0.0;
   params.GetDouble(guestview::kElementHeight, &element_height);
   params.GetDouble(guestview::kElementWidth, &element_width);
-  // Convert the element size from logical pixels to physical pixels.
-  int normal_height = LogicalPixelsToPhysicalPixels(element_height);
-  int normal_width = LogicalPixelsToPhysicalPixels(element_width);
+
+  // If the element size was provided in logical units (versus physical), then
+  // it will be converted to physical units.
+  bool element_size_is_logical = false;
+  if (params.HasKey(guestview::kElementSizeIsLogical)) {

[Fady Samuel, 2015/03/03 17:50:58]

This check seems unnecessary. Just call GetBoolean and set the default value
above?

[paulmeyer, 2015/03/03 20:36:23]

Done.

+    params.GetBoolean(guestview::kElementSizeIsLogical,
+                      &element_size_is_logical);
+  }
+  int normal_height = 0;
+  int normal_width = 0;
+  if (element_size_is_logical) {
+    // Convert the element size from logical pixels to physical pixels.
+    normal_height = LogicalPixelsToPhysicalPixels(element_height);
+    normal_width = LogicalPixelsToPhysicalPixels(element_width);
+  } else {
+    normal_height = lround(element_height);
+    normal_width = lround(element_width);
+  }
 
   SetSizeParams set_size_params;
   set_size_params.enable_auto_size.reset(new bool(auto_size_enabled));
   set_size_params.min_size.reset(new gfx::Size(min_width, min_height));
   set_size_params.max_size.reset(new gfx::Size(max_width, max_height));
   set_size_params.normal_size.reset(new gfx::Size(normal_width, normal_height));
 
   // Call SetSize to apply all the appropriate validation and clipping of
   // values.
   SetSize(set_size_params);
@@ skipping 31 matching lines @@
 void GuestViewBase::RegisterGuestViewTypes() {
   AppViewGuest::Register();
   ExtensionOptionsGuest::Register();
   ExtensionViewGuest::Register();
   MimeHandlerViewGuest::Register();
   SurfaceWorkerGuest::Register();
   WebViewGuest::Register();
 }
 
 }  // namespace extensions