Issue 972153004: Make ui::DisplayConfigurator a singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 972153004: Make ui::DisplayConfigurator a singleton (Closed)

Created:
5 years, 9 months ago by robert.bradford

Modified:
5 years, 4 months ago

Reviewers:

CC:
chromium-reviews, sadrul, hashimoto+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make ui::DisplayConfigurator a singleton This is currently instantiated from the ash::Shell. This change makes the object a singleton. The DisplayConfigurator::Init method is still called by the shell. BUG=425060 TEST=Compiles and ChromeOS UI functions correctly.

Patch Set 1 : Make a Singleton #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -13 lines)			Patch
M	ash/shell.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ash/shell.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/gpu/media/rendering_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/gpu/media/rendering_helper.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	extensions/shell/browser/shell_desktop_controller_aura.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/shell/browser/shell_desktop_controller_aura.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/display/chromeos/display_configurator.h	View	4 chunks	+13 lines, -3 lines	0 comments	Download
M	ui/display/chromeos/display_configurator.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/display/chromeos/display_configurator_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages