[bindings] Remove custom binding usage in SQLResultSetRowList.

Source/bindings/modules/v8/ScriptValueUtilities.h

Index: Source/bindings/modules/v8/ScriptValueUtilities.h
diff --git a/Source/bindings/modules/v8/ScriptValueUtilities.h b/Source/bindings/modules/v8/ScriptValueUtilities.h
new file mode 100644
index 0000000000000000000000000000000000000000..215b785ca5a82d4c83bd627a8149dd9699f6b42b
--- /dev/null
+++ b/Source/bindings/modules/v8/ScriptValueUtilities.h
@@ -0,0 +1,23 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ScriptValueUtilities_h
+#define ScriptValueUtilities_h
+
+#include "bindings/core/v8/ScriptValue.h"
+#include "bindings/core/v8/ToV8.h"
+#include "bindings/modules/v8/ToV8Utilities.h"
+#include "modules/webdatabase/sqlite/SQLValue.h"
+
+namespace blink {
+
+inline ScriptValue toScriptValue(ScriptState* scriptState, const Vector<std::pair<String, SQLValue>>& value)

[haraken, 2015/03/05 09:03:13]

Sorry, I'm probably missing what you've discussed, but can we put this function
to ScriptValue.h? I'm not super happy about increasing XXXUtilities.h.

[vivekg, 2015/03/05 09:13:53]

The reason we have put this under the binding/modules is due to the usage of
SQLValue which is module specific. 
And there will be one more addition here in this file with
https://codereview.chromium.org/949193002

e.g. Vector<SQLValue> toSQLValueArray(const Nullable<Vector<ScriptValue>>&
arguments)

[haraken, 2015/03/05 09:24:48]

ah, understood.

Can we put this function to SQLValue.h? There is no problem to use this function
in modules/ because this function is not using any V8 API. Both ScriptValue and
ScriptState are well-defined abstractions and it's OK to use them in core/ and
modules/ (we're already doing this in many places).

Sorry about an ambiguous rule. The rule is just that we want to avoid using V8
APIs (i.e., writing "v8::") in core/ and modules/.

[Yuki, 2015/03/05 09:25:20]

We can have the following template function:

template<typename T>
ScriptValue toScriptValue(ScriptState* scriptState, T value)
{
  return ScriptValue(scriptState, toV8(value, scriptState->context()->Global(),
scriptState->isolate()));
}

This doesn't directly depend on a specific type in modules/.
Also we don't need to add a new type support in addition to Vector<pair<String,
SQLValue>> in future.

+{
+    RELEASE_ASSERT(scriptState);

[haraken, 2015/03/05 09:03:13]

Remove this. We normally don't check this and we don't need to check this here
because if scriptState is 0, the below scriptState-> will just crash.

[vivekg, 2015/03/05 09:13:53]

Sure.

+    return ScriptValue(scriptState, toV8(value, scriptState->context()->Global(), scriptState->isolate()));
+}
+
+} // namespace blink
+
+#endif // ScriptValueUtilities_h