Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: Source/bindings/modules/v8/ScriptValueUtilities.h

Issue 972153002: [bindings] Remove custom binding usage in SQLResultSetRowList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@test
Patch Set: CallWith=ScriptState Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef ScriptValueUtilities_h
6 #define ScriptValueUtilities_h
7
8 #include "bindings/core/v8/ScriptValue.h"
9 #include "bindings/core/v8/ToV8.h"
10 #include "bindings/modules/v8/ToV8Utilities.h"
11 #include "modules/webdatabase/sqlite/SQLValue.h"
12
13 namespace blink {
14
15 inline ScriptValue toScriptValue(ScriptState* scriptState, const Vector<std::pai r<String, SQLValue>>& value)
haraken 2015/03/05 09:03:13 Sorry, I'm probably missing what you've discussed,
vivekg 2015/03/05 09:13:53 The reason we have put this under the binding/modu
haraken 2015/03/05 09:24:48 ah, understood. Can we put this function to SQLVa
Yuki 2015/03/05 09:25:20 We can have the following template function: temp
16 {
17 RELEASE_ASSERT(scriptState);
haraken 2015/03/05 09:03:13 Remove this. We normally don't check this and we d
vivekg 2015/03/05 09:13:53 Sure.
18 return ScriptValue(scriptState, toV8(value, scriptState->context()->Global() , scriptState->isolate()));
19 }
20
21 } // namespace blink
22
23 #endif // ScriptValueUtilities_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698