Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2457)

Unified Diff: Source/modules/webdatabase/SQLResultSetRowList.cpp

Issue 972153002: [bindings] Remove custom binding usage in SQLResultSetRowList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@test
Patch Set: Review comments addressed! Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webdatabase/SQLResultSetRowList.cpp
diff --git a/Source/modules/webdatabase/SQLResultSetRowList.cpp b/Source/modules/webdatabase/SQLResultSetRowList.cpp
index 1d16c5e4e84cfb40825699f0a7e9d65809161d43..ca377ba5a105b265a36ceb8dec83933afd1422bf 100644
--- a/Source/modules/webdatabase/SQLResultSetRowList.cpp
+++ b/Source/modules/webdatabase/SQLResultSetRowList.cpp
@@ -29,6 +29,9 @@
#include "config.h"
#include "modules/webdatabase/SQLResultSetRowList.h"
+#include "bindings/modules/v8/ScriptValueUtilities.h"
+#include "core/dom/ExceptionCode.h"
+
namespace blink {
unsigned SQLResultSetRowList::length() const
@@ -41,4 +44,21 @@ unsigned SQLResultSetRowList::length() const
return m_result.size() / m_columns.size();
}
+ScriptValue SQLResultSetRowList::item(unsigned index, ExceptionState& exceptionState)
+{
+ if (index >= length()) {
+ exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::indexExceedsMaximumBound<unsigned>("index", index, length()));
+ return ScriptValue();
+ }
+
+ unsigned numColumns = m_columns.size();
+ unsigned valuesIndex = index * numColumns;
+
+ Vector<std::pair<String, SQLValue>> dataArray;
+ for (unsigned i = 0; i < numColumns; ++i)
+ dataArray.append(std::make_pair(m_columns[i], m_result[valuesIndex + i]));
+
+ return toScriptValue(dataArray);
+}
+
}
Yuki 2015/03/05 03:31:03 nit: // namespace blink

Powered by Google App Engine
This is Rietveld 408576698