Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: Source/modules/webdatabase/SQLResultSetRowList.cpp

Issue 972153002: [bindings] Remove custom binding usage in SQLResultSetRowList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@test
Patch Set: Review comments addressed! Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 11 matching lines...) Expand all
22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #include "config.h" 29 #include "config.h"
30 #include "modules/webdatabase/SQLResultSetRowList.h" 30 #include "modules/webdatabase/SQLResultSetRowList.h"
31 31
32 #include "bindings/modules/v8/ScriptValueUtilities.h"
33 #include "core/dom/ExceptionCode.h"
34
32 namespace blink { 35 namespace blink {
33 36
34 unsigned SQLResultSetRowList::length() const 37 unsigned SQLResultSetRowList::length() const
35 { 38 {
36 if (m_result.size() == 0) 39 if (m_result.size() == 0)
37 return 0; 40 return 0;
38 41
39 ASSERT(m_result.size() % m_columns.size() == 0); 42 ASSERT(m_result.size() % m_columns.size() == 0);
40 43
41 return m_result.size() / m_columns.size(); 44 return m_result.size() / m_columns.size();
42 } 45 }
43 46
47 ScriptValue SQLResultSetRowList::item(unsigned index, ExceptionState& exceptionS tate)
48 {
49 if (index >= length()) {
50 exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::inde xExceedsMaximumBound<unsigned>("index", index, length()));
51 return ScriptValue();
52 }
53
54 unsigned numColumns = m_columns.size();
55 unsigned valuesIndex = index * numColumns;
56
57 Vector<std::pair<String, SQLValue>> dataArray;
58 for (unsigned i = 0; i < numColumns; ++i)
59 dataArray.append(std::make_pair(m_columns[i], m_result[valuesIndex + i]) );
60
61 return toScriptValue(dataArray);
44 } 62 }
63
64 }
Yuki 2015/03/05 03:31:03 nit: // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698