Chromecast: communicate HDMI-sink codec changes over IPC.

chromecast/common/media/cast_message_generator.h

Index: chromecast/common/media/cast_message_generator.h
diff --git a/ui/compositor/reflector.cc b/chromecast/common/media/cast_message_generator.h
similarity index 62%
copy from ui/compositor/reflector.cc
copy to chromecast/common/media/cast_message_generator.h
index 31dcdaef6105459ab2c82fa60cc5a1b6d03703f2..ac6c0041c5033cc9d7fad300e6361651c61e482f 100644
--- a/ui/compositor/reflector.cc
+++ b/chromecast/common/media/cast_message_generator.h
@@ -2,11 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ui/compositor/reflector.h"
+// Multiply-included file, hence no include guard.
 
-namespace ui {
+#include "chromecast/common/media/cast_messages.h"

[lcwu1, 2015/03/03 20:11:11]

It doesn't seem necessary to have multiple xxx_message_generator.[h|cc] here.
Could we merge cast_message_generator and cma_message_generator into one that
includes both cast_message.h and cma_message.h? (Having one message_generator
that includes multiple message headers also appear to be a common pattern in
both //content/ and //chrome/.)

(We might generate additional methods for cast_messages that are not used if we
combine the two, but I think that should be fine.)

[gunsch, 2015/03/04 02:35:47]

The choice to keep them separate isn't for idiomatic or stylistic reasons, but
rather because this file is common to both the Android/Linux cast_shell builds,
and the IPC traits we define for some of the common ::media structs cause
re-definition errors at link time.

I tried solving this awhile ago to be able to unconditionally include all the
CMA code (even though it's unused on Android), but the technical roadblock is
that we would have to move the IPC traits somewhere common to share them ---
currently they're content-private.

 
-Reflector::~Reflector() {
-}
-
-}  // namespace ui