chromecast/common/media/cast_message_generator.h - Issue 971913002: Chromecast: communicate HDMI-sink codec changes over IPC.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/common/media/cast_message_generator.h

Issue 971913002: Chromecast: communicate HDMI-sink codec changes over IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/compositor/reflector.h"	5 // Multiply-included file, hence no include guard.

6	6

7 namespace ui {	7 #include "chromecast/common/media/cast_messages.h"
	lcwu1 2015/03/03 20:11:11 It doesn't seem necessary to have multiple xxx_mes It doesn't seem necessary to have multiple xxx_message_generator.[h\|cc] here. Could we merge cast_message_generator and cma_message_generator into one that includes both cast_message.h and cma_message.h? (Having one message_generator that includes multiple message headers also appear to be a common pattern in both //content/ and //chrome/.) (We might generate additional methods for cast_messages that are not used if we combine the two, but I think that should be fine.) gunsch 2015/03/04 02:35:47 The choice to keep them separate isn't for idiomat The choice to keep them separate isn't for idiomatic or stylistic reasons, but rather because this file is common to both the Android/Linux cast_shell builds, and the IPC traits we define for some of the common ::media structs cause re-definition errors at link time. I tried solving this awhile ago to be able to unconditionally include all the CMA code (even though it's unused on Android), but the technical roadblock is that we would have to move the IPC traits somewhere common to share them --- currently they're content-private.
8	8

9 Reflector::~Reflector() {

10 }

11

12 } // namespace ui

OLD	NEW

« no previous file with comments | « chromecast/common/chromecast_switches.cc ('k') | chromecast/common/media/cast_message_generator.cc » ('j') | chromecast/media/base/media_caps.cc » ('J')