ozone: evdev: Sync caps lock LED state to evdev

ozone: evdev: Sync caps lock LED state to evdev

Update LED state in kernel in InputControllerEvdev::SetCapsLockEnabled.
This is currently the only way to toggle caps lock.

BUG=463242
TEST=plug in external keyboard on link_freon & press caps lock. Light on
  keyboard should turn on.

Committed: https://crrev.com/fc0faf53d30d331094b79fc77339184854169421
Cr-Commit-Position: refs/heads/master@{#318934}

[spang, 2015-03-02 22:00:33]

spang@chromium.org changed reviewers:
+ alexst@chromium.org, kpschoedel@chromium.org

[kpschoedel, 2015-03-02 22:19:35]

lgtm

https://codereview.chromium.org/971753006/diff/40001/ui/events/ozone/evdev/in...
File ui/events/ozone/evdev/input_controller_evdev.cc (right):

https://codereview.chromium.org/971753006/diff/40001/ui/events/ozone/evdev/in...
ui/events/ozone/evdev/input_controller_evdev.cc:63: if (input_device_factory_)
This doesn't thrill me because the connection between input_device_factory_ and
the LED isn't explicit here. Could the test be done below instead?

[alexst (slow to review), 2015-03-02 22:20:23]

https://codereview.chromium.org/971753006/diff/40001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.h (right):

https://codereview.chromium.org/971753006/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.h:65: // Leds for this device.
You use both Led and LED, it should probably be LED everywhere.

[spang, 2015-03-02 22:38:22]

https://codereview.chromium.org/971753006/diff/40001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.h (right):

https://codereview.chromium.org/971753006/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.h:65: // Leds for this device.
On 2015/03/02 22:20:23, alexst wrote:
> You use both Led and LED, it should probably be LED everywhere.

For camel case our code [relatively] consistently only capitalizes acronyms.

I agree for comments where we can use spaces. Fixed.

[spang, 2015-03-02 22:43:15]

https://codereview.chromium.org/971753006/diff/40001/ui/events/ozone/evdev/in...
File ui/events/ozone/evdev/input_controller_evdev.cc (right):

https://codereview.chromium.org/971753006/diff/40001/ui/events/ozone/evdev/in...
ui/events/ozone/evdev/input_controller_evdev.cc:63: if (input_device_factory_)
On 2015/03/02 22:19:35, kpschoedel wrote:
> This doesn't thrill me because the connection between input_device_factory_
and
> the LED isn't explicit here. Could the test be done below instead?

Done.

[alexst (slow to review), 2015-03-02 22:56:48]

lgtm

[spang, 2015-03-03 20:23:35]

The CQ bit was checked by spang@chromium.org

[spang, 2015-03-03 20:23:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
kpschoedel@chromium.org
Link to the patchset: https://codereview.chromium.org/971753006/#ps110001
(title: "s/PLOG/LOG/ for short write. errno is not set in this case")

[commit-bot: I haz the power, 2015-03-03 20:31:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/971753006/110001

[commit-bot: I haz the power, 2015-03-03 20:35:49]

Committed patchset #7 (id:110001)

[commit-bot: I haz the power, 2015-03-03 20:38:16]

Patchset 7 (id:??) landed as
https://crrev.com/fc0faf53d30d331094b79fc77339184854169421
Cr-Commit-Position: refs/heads/master@{#318934}