ui/events/ozone/evdev/event_modifiers_evdev.cc - Issue 971753006: ozone: evdev: Sync caps lock LED state to evdev

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/evdev/event_modifiers_evdev.cc

Issue 971753006: ozone: evdev: Sync caps lock LED state to evdev (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/PLOG/LOG/ for short write. errno is not set in this case Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/ozone/evdev/event_modifiers_evdev.cc

diff --git a/ui/events/ozone/evdev/event_modifiers_evdev.cc b/ui/events/ozone/evdev/event_modifiers_evdev.cc

index 70a62508aebcc08497e4425f461383d341822778..8ead0db581e4a4925e64fd4ae38e83cc28fef5c7 100644

--- a/ui/events/ozone/evdev/event_modifiers_evdev.cc

+++ b/ui/events/ozone/evdev/event_modifiers_evdev.cc

@@ -55,8 +55,6 @@ void EventModifiersEvdev::UpdateModifierLock(unsigned int modifier, bool down) {

if (down)

modifier_flags_locked_ ^= kEventFlagFromModifiers[modifier];

- // TODO(spang): Synchronize with the CapsLock LED.

UpdateFlags(modifier);

}

@@ -68,8 +66,6 @@ void EventModifiersEvdev::SetModifierLock(unsigned int modifier, bool locked) {

else

modifier_flags_locked_ &= ~kEventFlagFromModifiers[modifier];

- // TODO(spang): Synchronize with the CapsLock LED.

UpdateFlags(modifier);

}