Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 971653005: Roll ICU to eda9e75b to add the Windows data dll (Closed)

Created:
5 years, 9 months ago by jungshik at Google
Modified:
5 years, 9 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ICU to eda9e75b to add the Windows data dll v8 still uses the data dll (icudt.dll) on Windows. While building the Windows data dll, a few issues were discovered in the ICU data that were overlooked. Only one of them (the display name for Moldovan in Moldovan) is user-visible. ICU ( eda9e75b1fa17f57ffa369ee3543a2301b68d0a9 ) has fixes for them. In addition, fix the display name for 'mo' (which is actually 'ro-MD') and add a test. It's "broken" ever since ICU upgrade to 54.1. (See http://bugs.icu-project.org/trac/ticket/11563 ) BUG=428145 TEST=See https://codereview.chromium.org/878723002 for the list of tests. TEST=ui_base_unittests --gtest_filter=*Display* TBR=jochen@chromium.org Committed: https://crrev.com/b4394e13c04a366f11d3f3903c1427ae2a977863 Cr-Commit-Position: refs/heads/master@{#319114}

Patch Set 1 #

Patch Set 2 : fix mo display name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971653005/20001
5 years, 9 months ago (2015-03-04 18:32:10 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-04 19:17:19 UTC) #4
Michael Achenbach
Wondering why the deps patch applied as I rolled this already: https://codereview.chromium.org/977043004/
5 years, 9 months ago (2015-03-04 19:23:13 UTC) #5
jungshik at Google
On 2015/03/04 19:23:13, Michael Achenbach wrote: > Wondering why the deps patch applied as I ...
5 years, 9 months ago (2015-03-04 19:35:15 UTC) #6
Michael Achenbach
Yes bit_update is smart: Applying the patch. DEPS Checking patch DEPS... ... error: patch failed: ...
5 years, 9 months ago (2015-03-04 19:43:03 UTC) #7
Michael Achenbach
*bot_update
5 years, 9 months ago (2015-03-04 19:43:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 20:09:43 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 20:10:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4394e13c04a366f11d3f3903c1427ae2a977863
Cr-Commit-Position: refs/heads/master@{#319114}

Powered by Google App Engine
This is Rietveld 408576698