chrome/browser/thumbnails/thumbnail_service_impl.cc - Issue 971423002: Abstract code filtering URLs added to the history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/thumbnail_service_impl.cc

Issue 971423002: Abstract code filtering URLs added to the history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@keyed-service

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/thumbnails/thumbnail_service_impl.cc

diff --git a/chrome/browser/thumbnails/thumbnail_service_impl.cc b/chrome/browser/thumbnails/thumbnail_service_impl.cc

index ccd59c1ed26b27a3755901a289ac0fc40ae0c223..5ce53d9e398b4a1b656fe21a876d10fda327c909 100644

--- a/chrome/browser/thumbnails/thumbnail_service_impl.cc

+++ b/chrome/browser/thumbnails/thumbnail_service_impl.cc

@@ -8,6 +8,7 @@

#include "base/memory/ref_counted_memory.h"

#include "base/time/time.h"

#include "chrome/browser/history/history_service.h"

droger 2015/03/03 18:56:53 Can you remove this include?

+#include "chrome/browser/history/history_utils.h"

#include "chrome/browser/history/top_sites_factory.h"

#include "chrome/browser/thumbnails/content_based_thumbnailing_algorithm.h"

#include "chrome/browser/thumbnails/simple_thumbnail_crop.h"

@@ -99,7 +100,7 @@ bool ThumbnailServiceImpl::ShouldAcquirePageThumbnail(const GURL& url) {

return false;

// Skip if the given URL is not appropriate for history.

- if (!HistoryService::CanAddURL(url))

+ if (!CanAddURLToHistory(url))

return false;

// Skip if the top sites list is full, and the URL is not known.

if (local_ptr->IsNonForcedFull() && !local_ptr->IsKnownURL(url))

« no previous file with comments | « chrome/browser/history/top_sites_impl.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »