Abstract code filtering URLs added to the history

chrome/browser/thumbnails/thumbnail_service_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/thumbnails/thumbnail_service_impl.h"
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/time/time.h"
 #include "chrome/browser/history/history_service.h"

[droger, 2015/03/03 18:56:53]

Can you remove this include?

+#include "chrome/browser/history/history_utils.h"
 #include "chrome/browser/history/top_sites_factory.h"
 #include "chrome/browser/thumbnails/content_based_thumbnailing_algorithm.h"
 #include "chrome/browser/thumbnails/simple_thumbnail_crop.h"
 #include "chrome/browser/thumbnails/thumbnailing_context.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/search/search.h"
 #include "content/public/browser/browser_thread.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
@@ skipping 71 matching lines @@
   return new SimpleThumbnailCrop(thumbnail_size);
 }
 
 bool ThumbnailServiceImpl::ShouldAcquirePageThumbnail(const GURL& url) {
   scoped_refptr<history::TopSites> local_ptr(top_sites_);
 
   if (!local_ptr)
     return false;
 
   // Skip if the given URL is not appropriate for history.
-  if (!HistoryService::CanAddURL(url))
+  if (!CanAddURLToHistory(url))
     return false;
   // Skip if the top sites list is full, and the URL is not known.
   if (local_ptr->IsNonForcedFull() && !local_ptr->IsKnownURL(url))
     return false;
   // Skip if we don't have to udpate the existing thumbnail.
   ThumbnailScore current_score;
   if (local_ptr->GetPageThumbnailScore(url, &current_score) &&
       !current_score.ShouldConsiderUpdating())
     return false;
   // Skip if we don't have to udpate the temporary thumbnail (i.e. the one
   // not yet saved).
   ThumbnailScore temporary_score;
   if (local_ptr->GetTemporaryPageThumbnailScore(url, &temporary_score) &&
       !temporary_score.ShouldConsiderUpdating())
     return false;
 
   return true;
 }
 
 void ThumbnailServiceImpl::ShutdownOnUIThread() {
   // Since each call uses its own scoped_refptr, we can just clear the reference
   // here by assigning null. If another call is completed, it added its own
   // reference.
   top_sites_ = NULL;
 }
 
 }  // namespace thumbnails