Abstract code filtering URLs added to the history

Abstract code filtering URLs added to the history

Delegate to the embedder the decision to filter URLs to add to the history
through the HistoryClient defaulting to registering all URLs (in the base
class implementation but also when there is no HistoryClient during tests).

BUG=390953
TBR=jochen@chromium.org

Committed: https://crrev.com/73dc09820dcd45efbb42d162abff85f93edb7f0e
Cr-Commit-Position: refs/heads/master@{#319071}

[sdefresne, 2015-03-03 17:19:17]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2015-03-03 17:19:18]

Please take a look.

[droger, 2015-03-03 18:54:17]

lgtm

[droger, 2015-03-03 18:56:54]

https://codereview.chromium.org/971423002/diff/1/chrome/browser/thumbnails/th...
File chrome/browser/thumbnails/thumbnail_service_impl.cc (right):

https://codereview.chromium.org/971423002/diff/1/chrome/browser/thumbnails/th...
chrome/browser/thumbnails/thumbnail_service_impl.cc:10: #include
"chrome/browser/history/history_service.h"
Can you remove this include?

[sdefresne, 2015-03-04 09:57:45]

On 2015/03/03 18:56:54, droger wrote:
>
https://codereview.chromium.org/971423002/diff/1/chrome/browser/thumbnails/th...
> File chrome/browser/thumbnails/thumbnail_service_impl.cc (right):
> 
>
https://codereview.chromium.org/971423002/diff/1/chrome/browser/thumbnails/th...
> chrome/browser/thumbnails/thumbnail_service_impl.cc:10: #include
> "chrome/browser/history/history_service.h"
> Can you remove this include?

Done. Thank you for the review.

[sdefresne, 2015-03-04 10:20:49]

sdefresne@chromium.org changed reviewers:
+ jochen@chromium.org

[sdefresne, 2015-03-04 10:22:07]

TBR-ing jochen@chromium.org for chrome/browser/thumbnails/ change (using
top-level OWNERS as there is no OWNERS for chrome/browser/thumbnails/).

TRB-ing those changes since they are just updating client code after an API
change (from static method to free function).

[sdefresne, 2015-03-04 15:06:25]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-03-04 15:06:26]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/971423002/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2015-03-04 15:07:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/971423002/20001

[commit-bot: I haz the power, 2015-03-04 15:09:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-04 15:10:45]

Patchset 2 (id:??) landed as
https://crrev.com/73dc09820dcd45efbb42d162abff85f93edb7f0e
Cr-Commit-Position: refs/heads/master@{#319071}