Removing FRE UI for unicorn accounts.

chrome/browser/supervised_user/child_accounts/flags_fetching_observer.h

Index: chrome/browser/supervised_user/child_accounts/flags_fetching_observer.h
diff --git a/chrome/browser/supervised_user/child_accounts/flags_fetching_observer.h b/chrome/browser/supervised_user/child_accounts/flags_fetching_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..33744fd04b30581fa6c0a7ef39b8ffd944504206
--- /dev/null
+++ b/chrome/browser/supervised_user/child_accounts/flags_fetching_observer.h
@@ -0,0 +1,19 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_FLAGS_FETCHING_OBSERVER_H_
+#define CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_FLAGS_FETCHING_OBSERVER_H_
+
+class FlagsFetchingObserver {

[Marc Treib, 2015/03/04 09:59:15]

I'd call this something like ChildAccountStatusObserver, and have only a single
ChildAccountStatusChanged(bool is_child) method. All the other methods don't
really tell the observer anything useful.

Also, nit: indentation is wrong in this file.

[merkulova, 2015/03/04 10:06:27]

they say that fetching stopped (for any reason). Do you think it's not necessary
for FRE decision?

Ack regarding naming.

[Marc Treib, 2015/03/04 10:17:53]

But the fetching never actually stops - if there's an error, we retry. So I'd
say the observer doesn't actually care about the fetching at all, it just wants
to know if this is a child account.
I'd formulate the FRE logic as: Wait until we know whether this is a child
account. If we still don't know after n seconds, give up and assume it's a
regular account.

[merkulova, 2015/03/04 14:55:12]

Acknowledged.

+  public:
+    virtual void OnFlagsFetchingStarted() {}
+
+    virtual void OnFlagsFetchingError() {}
+
+    virtual void OnFlagsFetchingCancelled() {}
+
+    virtual void OnFlagsFetchingCompleted(bool is_child_account) {}
+};
+
+#endif  // CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_FLAGS_FETCHING_OBSERVER_H_