chrome/browser/supervised_user/child_accounts/flags_fetching_observer.h - Issue 971383002: Removing FRE UI for unicorn accounts.

Side by Side Diff: chrome/browser/supervised_user/child_accounts/flags_fetching_observer.h

Issue 971383002: Removing FRE UI for unicorn accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/supervised_user/child_accounts/child_account_service.cc ('K') | « chrome/browser/supervised_user/child_accounts/child_account_service.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_FLAGS_FETCHING_OBSERVER_H_

	6 #define CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_FLAGS_FETCHING_OBSERVER_H_

	7

	8 class FlagsFetchingObserver {
	Marc Treib 2015/03/04 09:59:15 I'd call this something like ChildAccountStatusObs I'd call this something like ChildAccountStatusObserver, and have only a single ChildAccountStatusChanged(bool is_child) method. All the other methods don't really tell the observer anything useful. Also, nit: indentation is wrong in this file. merkulova 2015/03/04 10:06:27 they say that fetching stopped (for any reason). D Show quoted text On 2015/03/04 09:59:15, Marc Treib wrote: > I'd call this something like ChildAccountStatusObserver, and have only a single > ChildAccountStatusChanged(bool is_child) method. All the other methods don't > really tell the observer anything useful. > > Also, nit: indentation is wrong in this file. they say that fetching stopped (for any reason). Do you think it's not necessary for FRE decision? Ack regarding naming. Marc Treib 2015/03/04 10:17:53 But the fetching never actually stops - if there's Show quoted text On 2015/03/04 10:06:27, merkulova wrote: > On 2015/03/04 09:59:15, Marc Treib wrote: > > I'd call this something like ChildAccountStatusObserver, and have only a > single > > ChildAccountStatusChanged(bool is_child) method. All the other methods don't > > really tell the observer anything useful. > > > > Also, nit: indentation is wrong in this file. > > they say that fetching stopped (for any reason). Do you think it's not necessary > for FRE decision? > > Ack regarding naming. But the fetching never actually stops - if there's an error, we retry. So I'd say the observer doesn't actually care about the fetching at all, it just wants to know if this is a child account. I'd formulate the FRE logic as: Wait until we know whether this is a child account. If we still don't know after n seconds, give up and assume it's a regular account. merkulova 2015/03/04 14:55:12 Acknowledged. Show quoted text On 2015/03/04 10:17:53, Marc Treib wrote: > On 2015/03/04 10:06:27, merkulova wrote: > > On 2015/03/04 09:59:15, Marc Treib wrote: > > > I'd call this something like ChildAccountStatusObserver, and have only a > > single > > > ChildAccountStatusChanged(bool is_child) method. All the other methods don't > > > really tell the observer anything useful. > > > > > > Also, nit: indentation is wrong in this file. > > > > they say that fetching stopped (for any reason). Do you think it's not > necessary > > for FRE decision? > > > > Ack regarding naming. > > But the fetching never actually stops - if there's an error, we retry. So I'd > say the observer doesn't actually care about the fetching at all, it just wants > to know if this is a child account. > I'd formulate the FRE logic as: Wait until we know whether this is a child > account. If we still don't know after n seconds, give up and assume it's a > regular account. Acknowledged.
	9 public:

	10 virtual void OnFlagsFetchingStarted() {}

	11

	12 virtual void OnFlagsFetchingError() {}

	13

	14 virtual void OnFlagsFetchingCancelled() {}

	15

	16 virtual void OnFlagsFetchingCompleted(bool is_child_account) {}

	17 };

	18

	19 #endif // CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_FLAGS_FETCHING_OBSERVER _H_

OLD	NEW