Issue 971323002: Added missing Privacy And Security Settings to Content Settings Sample extension.

Issue 971323002: Added missing Privacy And Security Settings to Content Settings Sample extension. (Closed)

Created:
5 years, 9 months ago by François Beaufort

Modified:
5 years, 9 months ago

Reviewers:
Mike West, not at google - send to devlin

CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Added missing Privacy And Security Settings to Content Settings Sample extension. R=mkwst@chromium.org Committed: https://crrev.com/a54ae4fff11acb63e105fbc88151e7f2ff4107da Cr-Commit-Position: refs/heads/master@{#319030}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -12 lines)			Patch
	M	chrome/common/extensions/docs/examples/api/contentSettings/popup.html	View		1 chunk	+47 lines, -9 lines	0 comments	Download
	M	chrome/common/extensions/docs/examples/api/contentSettings/popup.js	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Total messages: 10 (2 generated)

François Beaufort

Hey Benjamin, Do you mind having a look at this sample update based on new ...

5 years, 9 months ago (2015-03-03 13:30:30 UTC) #1

not at google - send to devlin

Mike could you check this? I'll lg then. Also plz don't just TBR me.

5 years, 9 months ago (2015-03-03 17:30:58 UTC) #3

François Beaufort

On 2015/03/03 17:33:38, kalman wrote: > lgtm Thank you Mike. Benjamin, sorry for the not-even ...

5 years, 9 months ago (2015-03-04 07:46:39 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971323002/1

5 years, 9 months ago (2015-03-04 07:46:51 UTC) #8

commit-bot: I haz the power

5 years, 9 months ago (2015-03-04 08:20:01 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a54ae4fff11acb63e105fbc88151e7f2ff4107da
Cr-Commit-Position: refs/heads/master@{#319030}