Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: chrome/common/extensions/docs/examples/api/contentSettings/popup.js

Issue 971323002: Added missing Privacy And Security Settings to Content Settings Sample extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/examples/api/contentSettings/popup.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/examples/api/contentSettings/popup.js
diff --git a/chrome/common/extensions/docs/examples/api/contentSettings/popup.js b/chrome/common/extensions/docs/examples/api/contentSettings/popup.js
index ed2dfc7933e6edf5b229482de93514502b954958..74ef60d88edd85a36f66d9fc5d2fbb711bf3c0fc 100644
--- a/chrome/common/extensions/docs/examples/api/contentSettings/popup.js
+++ b/chrome/common/extensions/docs/examples/api/contentSettings/popup.js
@@ -25,17 +25,20 @@ document.addEventListener('DOMContentLoaded', function () {
var current = tabs[0];
incognito = current.incognito;
url = current.url;
- var types = ['cookies', 'images', 'javascript', 'plugins', 'popups',
- 'notifications'];
+ var types = ['cookies', 'images', 'javascript', 'location', 'plugins',
+ 'popups', 'notifications', 'fullscreen', 'mouselock',
+ 'microphone', 'camera', 'unsandboxedPlugins',
+ 'automaticDownloads'];
types.forEach(function(type) {
// HACK: [type] is not recognised by the docserver's sample crawler, so
// mention an explicit
// type: chrome.contentSettings.cookies.get - See http://crbug.com/299634
- chrome.contentSettings[type].get({
+ chrome.contentSettings[type] && chrome.contentSettings[type].get({
'primaryUrl': url,
'incognito': incognito
},
function(details) {
+ document.getElementById(type).disabled = false;
document.getElementById(type).value = details.setting;
});
});
« no previous file with comments | « chrome/common/extensions/docs/examples/api/contentSettings/popup.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698