Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 971073002: Make Data Saver integration test use new secure proxy check URL flag. (Closed)

Created:
5 years, 9 months ago by sclittle
Modified:
5 years, 9 months ago
Reviewers:
bengr, bustamante
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Data Saver integration test use new secure proxy check URL flag. The flag for specifying the URL for the Data Saver secure proxy check was changed in https://codereview.chromium.org/961983002/. This change makes the relevant integration test use the new flag value, and also makes the test restart after each page. BUG=463210 Committed: https://crrev.com/fce897d260ef5bcd778b34ace234e233f9afa83b Cr-Commit-Position: refs/heads/master@{#318923}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 1 chunk +4 lines, -4 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
sclittle
PTAL
5 years, 9 months ago (2015-03-02 22:22:43 UTC) #2
sclittle
PTAL
5 years, 9 months ago (2015-03-02 22:24:43 UTC) #3
bustamante
lgtm
5 years, 9 months ago (2015-03-02 22:26:21 UTC) #4
bengr
lgtm https://codereview.chromium.org/971073002/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right): https://codereview.chromium.org/971073002/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py#newcode209 tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:209: restart_after_each_page=True) I suppose this is ok, but in ...
5 years, 9 months ago (2015-03-03 17:49:29 UTC) #5
sclittle
https://codereview.chromium.org/971073002/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right): https://codereview.chromium.org/971073002/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py#newcode209 tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:209: restart_after_each_page=True) On 2015/03/03 17:49:29, bengr wrote: > I suppose ...
5 years, 9 months ago (2015-03-03 18:14:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971073002/1
5 years, 9 months ago (2015-03-03 18:15:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 19:11:18 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 19:12:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fce897d260ef5bcd778b34ace234e233f9afa83b
Cr-Commit-Position: refs/heads/master@{#318923}

Powered by Google App Engine
This is Rietveld 408576698