Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Issue 971073002: Make Data Saver integration test use new secure proxy check URL flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
index 10ed99b2bb2bc00b0d9459b18406abc0cf3c105a..f58bb03de30dfdd5259a861a9ce820d565538a05 100644
--- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
@@ -205,17 +205,17 @@ class ChromeProxyHTTPFallbackProbeURL(ChromeProxyValidation):
"""
def __init__(self):
- super(ChromeProxyHTTPFallbackProbeURL, self).__init__()
+ super(ChromeProxyHTTPFallbackProbeURL, self).__init__(
+ restart_after_each_page=True)
bengr 2015/03/03 17:49:29 I suppose this is ok, but in the future, please do
sclittle 2015/03/03 18:14:35 OK.
def CustomizeBrowserOptions(self, options):
super(ChromeProxyHTTPFallbackProbeURL,
self).CustomizeBrowserOptions(options)
# Use the test server probe URL which returns the response
# body as specified by respBody.
- probe_url = GetResponseOverrideURL(
- respBody='not OK')
+ probe_url = GetResponseOverrideURL(respBody='not OK')
options.AppendExtraBrowserArgs(
- '--data-reduction-proxy-probe-url=%s' % probe_url)
+ '--data-reduction-proxy-secure-proxy-check-url=%s' % probe_url)
def AddResults(self, tab, results):
self._metrics.AddResultsForHTTPFallback(tab, results)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698