Sets the native name of static native methods by using the @JSName with the @Native tag of the encl…

Sets the native name of static native methods by using the @JSName with the @Native tag of the enclosing class.

BUG=22483
R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44201

[Harry Terkelsen, 2015-03-03 01:17:00]

het@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-03-03 02:00:02]

https://codereview.chromium.org/971053003/diff/1/pkg/compiler/lib/src/native/...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/971053003/diff/1/pkg/compiler/lib/src/native/...
pkg/compiler/lib/src/native/enqueue.dart:403: setStaticNativeMethodName(method);
better name:  setNativeNameForStaticMethod

https://codereview.chromium.org/971053003/diff/1/pkg/compiler/lib/src/native/...
pkg/compiler/lib/src/native/enqueue.dart:430: String nativeName =
unquote(element.enclosingClass.nativeTagInfo);
There is code somewhere that parses the tag info.
Find that and use it.
The parsing should occur in only one place.
If the native tag info is messed up we need the compiler to signal an error
rather than generate bad code.

@Native("ApplicationCache,DOMApplicationCache,OfflineResourceList")
class ApplicationCache extends EventTarget {

https://codereview.chromium.org/971053003/diff/1/pkg/compiler/lib/src/native/...
pkg/compiler/lib/src/native/enqueue.dart:438: new
RegExp(r'^[a-zA-Z_$][a-zA-Z0-9_$]*$').hasMatch(s);
Put regexp in a static class variable so it is not parsed and compiled each
time.

[Harry Terkelsen, 2015-03-03 02:04:33]

het@google.com changed reviewers:
+ floitsch@google.com

[Harry Terkelsen, 2015-03-03 03:02:17]

Thanks Stephen, PTAL

https://codereview.chromium.org/971053003/diff/1/pkg/compiler/lib/src/native/...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/971053003/diff/1/pkg/compiler/lib/src/native/...
pkg/compiler/lib/src/native/enqueue.dart:403: setStaticNativeMethodName(method);
On 2015/03/03 02:00:02, sra1 wrote:
> better name:  setNativeNameForStaticMethod

Done.

https://codereview.chromium.org/971053003/diff/1/pkg/compiler/lib/src/native/...
pkg/compiler/lib/src/native/enqueue.dart:430: String nativeName =
unquote(element.enclosingClass.nativeTagInfo);
On 2015/03/03 02:00:02, sra1 wrote:
> There is code somewhere that parses the tag info.
> Find that and use it.
> The parsing should occur in only one place.
> If the native tag info is messed up we need the compiler to signal an error
> rather than generate bad code.
> 
> @Native("ApplicationCache,DOMApplicationCache,OfflineResourceList")
> class ApplicationCache extends EventTarget {

Done.

https://codereview.chromium.org/971053003/diff/1/pkg/compiler/lib/src/native/...
pkg/compiler/lib/src/native/enqueue.dart:438: new
RegExp(r'^[a-zA-Z_$][a-zA-Z0-9_$]*$').hasMatch(s);
On 2015/03/03 02:00:02, sra1 wrote:
> Put regexp in a static class variable so it is not parsed and compiled each
> time.

Done.

[sra1, 2015-03-03 20:55:27]

lgtm

[Harry Terkelsen, 2015-03-03 21:51:42]

Committed patchset #2 (id:20001) manually as 44201 (presubmit successful).