Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: win8/delegate_execute/delegate_execute.cc

Issue 970943003: Remove base::KillProcessById (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/stress_cache/stress_cache.cc ('k') | win8/delegate_execute/delegate_execute_operation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win8/delegate_execute/delegate_execute.cc
diff --git a/win8/delegate_execute/delegate_execute.cc b/win8/delegate_execute/delegate_execute.cc
index 0d2bbbb00630ce0dfd15e4e9b37a46f75acdedda..2574619867595d62e289344acf8606ffdfdeac18 100644
--- a/win8/delegate_execute/delegate_execute.cc
+++ b/win8/delegate_execute/delegate_execute.cc
@@ -108,9 +108,9 @@ int RelaunchChrome(const DelegateExecuteOperation& operation) {
AtlTrace("Unexpected release of the relaunch mutex!!\n");
} else if (result == WAIT_TIMEOUT) {
// This could mean that Chrome is hung. Proceed to exterminate.
- DWORD pid = operation.GetParentPid();
- AtlTrace("%ds timeout. Killing Chrome %d\n", kWaitSeconds, pid);
- base::KillProcessById(pid, 0, false);
+ base::Process process = operation.GetParent();
+ AtlTrace("%ds timeout. Killing Chrome %d\n", kWaitSeconds, process.Pid());
+ process.Terminate(0);
} else {
AtlTrace("Failed to wait for relaunch mutex, result is 0x%x\n", result);
}
« no previous file with comments | « net/tools/stress_cache/stress_cache.cc ('k') | win8/delegate_execute/delegate_execute_operation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698