Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 970943003: Remove base::KillProcessById (Closed)

Created:
5 years, 9 months ago by rvargas (doing something else)
Modified:
5 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::KillProcessById BUG=417532 Committed: https://crrev.com/4683e5ee356b1ba60813306ff6cb12de80060143 Cr-Commit-Position: refs/heads/master@{#319143}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -40 lines) Patch
M base/process/kill.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M base/process/kill.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M base/process/kill_win.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/tools/stress_cache/stress_cache.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M win8/delegate_execute/delegate_execute_operation.h View 2 chunks +3 lines, -2 lines 0 comments Download
M win8/delegate_execute/delegate_execute_operation.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rvargas (doing something else)
5 years, 9 months ago (2015-03-03 03:23:52 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-03 22:23:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970943003/20001
5 years, 9 months ago (2015-03-04 20:26:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 22:38:36 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 22:39:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4683e5ee356b1ba60813306ff6cb12de80060143
Cr-Commit-Position: refs/heads/master@{#319143}

Powered by Google App Engine
This is Rietveld 408576698