Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 97073004: Make Time functions go through the Platform layer. (Closed)

Created:
7 years ago by pwnall-personal
Modified:
6 years, 6 months ago
CC:
v8-dev, Paweł Hajdan Jr., tfarina
Base URL:
git://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

Make Time functions go through the Platform layer. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -549 lines) Patch
M include/v8-platform.h View 1 chunk +59 lines, -0 lines 0 comments Download
M src/default-platform.h View 1 chunk +5 lines, -0 lines 0 comments Download
A + src/platform/default-platform-time.cc View 6 chunks +24 lines, -276 lines 0 comments Download
M src/platform/time.cc View 5 chunks +8 lines, -273 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eseidel
Did you mean to send this for review? (rietveld doesn't mail when you upload)
6 years, 8 months ago (2014-04-10 05:27:59 UTC) #1
pwnall-personal
On 2014/04/10 05:27:59, eseidel wrote: > Did you mean to send this for review? (rietveld ...
6 years, 8 months ago (2014-04-10 11:20:59 UTC) #2
tfarina
I think Benedikt and Sven are better reviewers for this. Thanks,
6 years, 8 months ago (2014-04-10 18:51:13 UTC) #3
Benedikt Meurer
Forwarding to jochen@ for review.
6 years, 8 months ago (2014-04-11 07:12:04 UTC) #4
jochen (gone - plz use gerrit)
as mentioned over email, I'd first like to make progress on encapsulating the default platform ...
6 years, 8 months ago (2014-04-14 07:41:21 UTC) #5
eseidel
Given how much V8 changes, I suspect this no longer applies. Jochen: has there been ...
6 years, 6 months ago (2014-05-29 00:43:11 UTC) #6
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-02 07:35:03 UTC) #7
On 2014/05/29 00:43:11, eseidel wrote:
> Given how much V8 changes, I suspect this no longer applies.
> 
> Jochen: has there been any change to encapsulation or should we just close
this?
>  I don't believe pwnall is active in Chromium atm.

we're still not at a point where this patch would make sense. I guess we can
close it

Powered by Google App Engine
This is Rietveld 408576698