Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 970603002: Sync the Element interface with the many specs (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the Element interface with the many specs https://dom.spec.whatwg.org/#interface-element and many other specs with partial Element interfaces. Arguments named namespace were not renamed, as it is a C++ keyword. No FIXMEs were added where the spec says [TreatNullAs=EmptyString] but we use [TreatNullAs=NullString], as that's a general issue that can be found simply be searching for "TreatNullAs=NullString". Likewise, [NewObject] and [SameObject] were not added: https://code.google.com/p/chromium/issues/detail?id=462913 The only changes to the generated code are due to renamed arguments. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191079

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M Source/core/dom/Element.idl View 6 chunks +20 lines, -15 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
philipj_slow
PTAL, depends on https://codereview.chromium.org/970553002/
5 years, 9 months ago (2015-03-01 01:44:52 UTC) #2
haraken
LGTM https://codereview.chromium.org/970603002/diff/1/Source/core/dom/Element.idl File Source/core/dom/Element.idl (right): https://codereview.chromium.org/970603002/diff/1/Source/core/dom/Element.idl#newcode82 Source/core/dom/Element.idl:82: // FIXME: scrollIntoView() should have a ScrollIntoViewOptions dictionary ...
5 years, 9 months ago (2015-03-01 08:58:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970603002/1
5 years, 9 months ago (2015-03-02 00:04:02 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 05:02:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191079

Powered by Google App Engine
This is Rietveld 408576698