Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: Source/core/dom/Element.idl

Issue 970603002: Sync the Element interface with the many specs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.idl
diff --git a/Source/core/dom/Element.idl b/Source/core/dom/Element.idl
index e92e09e7d7445e54fa295d2d4628febbad6cff53..2c4606f334f6f31f26ba4cb18163aea5f95b829a 100644
--- a/Source/core/dom/Element.idl
+++ b/Source/core/dom/Element.idl
@@ -25,6 +25,7 @@
] interface Element : Node {
readonly attribute DOMString? namespaceURI;
readonly attribute DOMString? prefix;
+ // FIXME: localName/tagName should not be nullable.
readonly attribute DOMString? localName;
readonly attribute DOMString? tagName;
@@ -33,26 +34,26 @@
[PerWorldBindings] readonly attribute DOMTokenList classList;
[MeasureAs=HasAttributes] boolean hasAttributes();
- [PerWorldBindings, ImplementedAs=attributesForBindings] readonly attribute NamedNodeMap attributes;
+ [PerWorldBindings, ImplementedAs=attributesForBindings] readonly attribute NamedNodeMap attributes;
DOMString? getAttribute(DOMString name);
DOMString? getAttributeNS(DOMString? namespaceURI, DOMString localName);
[RaisesException, CustomElementCallbacks] void setAttribute(DOMString name, DOMString value);
- [RaisesException, CustomElementCallbacks] void setAttributeNS(DOMString? namespaceURI, DOMString qualifiedName, DOMString value);
+ [RaisesException, CustomElementCallbacks] void setAttributeNS(DOMString? namespaceURI, DOMString name, DOMString value);
[CustomElementCallbacks] void removeAttribute(DOMString name);
[CustomElementCallbacks] void removeAttributeNS(DOMString? namespaceURI, DOMString localName);
boolean hasAttribute(DOMString name);
boolean hasAttributeNS(DOMString? namespaceURI, DOMString localName);
- [MeasureAs=ElementGetAttributeNode] Attr getAttributeNode(DOMString name);
- [MeasureAs=ElementGetAttributeNodeNS] Attr getAttributeNodeNS(DOMString? namespaceURI, DOMString localName);
- [RaisesException, CustomElementCallbacks, MeasureAs=ElementSetAttributeNode] Attr setAttributeNode(Attr newAttr);
- [RaisesException, CustomElementCallbacks, MeasureAs=ElementSetAttributeNodeNS] Attr setAttributeNodeNS(Attr newAttr);
- [RaisesException, CustomElementCallbacks, MeasureAs=ElementRemoveAttributeNode] Attr removeAttributeNode(Attr oldAttr);
+ [MeasureAs=ElementGetAttributeNode] Attr? getAttributeNode(DOMString name);
+ [MeasureAs=ElementGetAttributeNodeNS] Attr? getAttributeNodeNS(DOMString? namespaceURI, DOMString localName);
+ [RaisesException, CustomElementCallbacks, MeasureAs=ElementSetAttributeNode] Attr? setAttributeNode(Attr attr);
+ [RaisesException, CustomElementCallbacks, MeasureAs=ElementSetAttributeNodeNS] Attr? setAttributeNodeNS(Attr attr);
+ [RaisesException, CustomElementCallbacks, MeasureAs=ElementRemoveAttributeNode] Attr removeAttributeNode(Attr attr);
- [RaisesException] Element closest(DOMString selectors);
+ [RaisesException] Element? closest(DOMString selectors);
[RaisesException] boolean matches(DOMString selectors);
- HTMLCollection getElementsByTagName(DOMString name);
+ HTMLCollection getElementsByTagName(DOMString localName);
HTMLCollection getElementsByTagNameNS(DOMString? namespaceURI, DOMString localName);
HTMLCollection getElementsByClassName(DOMString classNames);
@@ -60,13 +61,13 @@
// https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#extensions-to-the-element-interface
[TreatNullAs=NullString, CustomElementCallbacks, RaisesException=Setter, ExposeJSAccessors] attribute DOMString innerHTML;
[TreatNullAs=NullString, CustomElementCallbacks, RaisesException=Setter] attribute DOMString outerHTML;
- [CustomElementCallbacks, RaisesException, MeasureAs=InsertAdjacentHTML] void insertAdjacentHTML(DOMString where, DOMString html);
+ [CustomElementCallbacks, RaisesException, MeasureAs=InsertAdjacentHTML] void insertAdjacentHTML(DOMString position, DOMString text);
// Shadow DOM
// http://w3c.github.io/webcomponents/spec/shadow/#extensions-to-element-interface
[RaisesException, MeasureAs=ElementCreateShadowRoot] ShadowRoot createShadowRoot();
NodeList getDestinationInsertionPoints();
- [PerWorldBindings] readonly attribute ShadowRoot shadowRoot;
+ [PerWorldBindings] readonly attribute ShadowRoot? shadowRoot;
// Pointer Lock
// https://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html#extensions-to-the-element-interface
@@ -74,14 +75,17 @@
// CSSOM View Module
// http://dev.w3.org/csswg/cssom-view/#extension-to-the-element-interface
+ // FIXME: getClientRect() and getBoundingClientRect() should
+ // return DOMRectList and DOMRect respectively.
ClientRectList getClientRects();
ClientRect getBoundingClientRect();
+ // FIXME: scrollIntoView() should have a ScrollIntoViewOptions dictionary argument.
haraken 2015/03/01 08:58:35 +bashi, FYI.
void scrollIntoView(optional boolean alignWithTop);
- [RuntimeEnabled=CSSOMSmoothScroll, ImplementedAs=scrollTo] void scroll(optional ScrollToOptions scrollToOptions);
+ [RuntimeEnabled=CSSOMSmoothScroll, ImplementedAs=scrollTo] void scroll(optional ScrollToOptions options);
[RuntimeEnabled=CSSOMSmoothScroll, ImplementedAs=scrollTo] void scroll(unrestricted double x, unrestricted double y);
- [RuntimeEnabled=CSSOMSmoothScroll] void scrollTo(optional ScrollToOptions scrollToOptions);
+ [RuntimeEnabled=CSSOMSmoothScroll] void scrollTo(optional ScrollToOptions options);
[RuntimeEnabled=CSSOMSmoothScroll] void scrollTo(unrestricted double x, unrestricted double y);
- [RuntimeEnabled=CSSOMSmoothScroll] void scrollBy(optional ScrollToOptions scrollToOptions);
+ [RuntimeEnabled=CSSOMSmoothScroll] void scrollBy(optional ScrollToOptions options);
[RuntimeEnabled=CSSOMSmoothScroll] void scrollBy(unrestricted double x, unrestricted double y);
attribute unrestricted double scrollTop;
attribute unrestricted double scrollLeft;
@@ -93,7 +97,7 @@
readonly attribute long clientHeight;
// http://dev.w3.org/csswg/cssom-view/#extensions-to-the-htmlelement-interface
// FIXME: offset* should be on HTMLElement.
- [ImplementedAs=offsetParentForBindings, PerWorldBindings] readonly attribute Element offsetParent;
+ [ImplementedAs=offsetParentForBindings, PerWorldBindings] readonly attribute Element? offsetParent;
readonly attribute long offsetTop;
readonly attribute long offsetLeft;
readonly attribute long offsetWidth;
@@ -102,6 +106,7 @@
// CSS Object Model (CSSOM)
// http://dev.w3.org/csswg/cssom/#the-elementcssinlinestyle-interface
// FIXME: style should be on HTMLElement and SVGElement.
+ // FIXME: style should have [PutForwards=cssText].
[PerWorldBindings] readonly attribute CSSStyleDeclaration style;
// HTML
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698