Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 970403002: Don't suggest autofill profiles that are subsets of other profiles. (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't suggest autofill profiles that are subsets of other profiles. Before this patch, we had code to avoid showing duplicates, but it would not prevent showing subsets. For example, if you had profiles: - Daisy Green, 123 Main, Littleton, CO - Daisy Green, 123 Main, Littleton, CO, 80161 It would suggest both. BUG=463305 Committed: https://crrev.com/5617cd9cfaab4b623cb2ffbc5e0cb2d8e70a148a Cr-Commit-Position: refs/heads/master@{#319539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -61 lines) Patch
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 3 chunks +77 lines, -32 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +45 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
5 years, 9 months ago (2015-03-04 00:06:14 UTC) #2
Evan Stade
ping
5 years, 9 months ago (2015-03-05 18:37:38 UTC) #3
brettw
Sorry, this is the third time I've looked at this review without sending email :( ...
5 years, 9 months ago (2015-03-06 17:26:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970403002/1
5 years, 9 months ago (2015-03-06 20:32:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-07 00:31:02 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 00:31:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5617cd9cfaab4b623cb2ffbc5e0cb2d8e70a148a
Cr-Commit-Position: refs/heads/master@{#319539}

Powered by Google App Engine
This is Rietveld 408576698