Don't suggest autofill profiles that are subsets of other profiles.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 49 matching lines @@
 // The rate for positive/negative matches potentially could be different.
 const double kAutofillPositiveUploadRateDefaultValue = 0.20;
 const double kAutofillNegativeUploadRateDefaultValue = 0.20;
 
 const size_t kMaxRecentFormSignaturesToRemember = 3;
 
 // Set a conservative upper bound on the number of forms we are willing to
 // cache, simply to prevent unbounded memory consumption.
 const size_t kMaxFormCacheSize = 100;
 
-// Removes duplicate suggestions whilst preserving their original order.
-void RemoveDuplicateSuggestions(std::vector<Suggestion>* suggestions) {
-  std::set<std::pair<base::string16, base::string16>> seen_suggestions;
-
-  for (int i = 0; i < static_cast<int>(suggestions->size()); ++i) {
-    if (!seen_suggestions.insert(std::make_pair(
-            (*suggestions)[i].value, (*suggestions)[i].label)).second) {
-      // Duplicate found, delete it.
-      suggestions->erase(suggestions->begin() + i);
-      i--;
-    }
-  }
-}
-
 // Precondition: |form_structure| and |form| should correspond to the same
 // logical form.  Returns true if any field in the given |section| within |form|
 // is auto-filled.
 bool SectionIsAutofilled(const FormStructure& form_structure,
                          const FormData& form,
                          const std::string& section) {
   DCHECK_EQ(form_structure.field_count(), form.fields.size());
   for (size_t i = 0; i < form_structure.field_count(); ++i) {
     if (form_structure.field(i)->section() == section &&
         form.fields[i].is_autofilled) {
@@ skipping 433 matching lines @@
           // If the relevant section is auto-filled and the renderer is querying
           // for suggestions, then the user is editing the value of a field.
           // In this case, mimic autocomplete: don't display labels or icons,
           // as that information is redundant.
           for (size_t i = 0; i < suggestions.size(); i++) {
             suggestions[i].label = base::string16();
             suggestions[i].icon = base::string16();
           }
         }
 
-        // When filling credit card suggestions, the values and labels are
-        // typically obfuscated, which makes detecting duplicates hard.  Since
-        // duplicates only tend to be a problem when filling address forms
-        // anyway, only don't de-dup credit card suggestions.
-        if (!is_filling_credit_card)
-          RemoveDuplicateSuggestions(&suggestions);
-
         // The first time we show suggestions on this page, log the number of
         // suggestions available.
         // TODO(mathp): Differentiate between number of suggestions available
         // (current metric) and number shown to the user.
         if (!has_logged_address_suggestions_count_ && !section_is_autofilled) {
           AutofillMetrics::LogAddressSuggestionsCount(suggestions.size());
           has_logged_address_suggestions_count_ = true;
         }
       }
     }
@@ skipping 909 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed())
     return false;
 
   return true;
 }
 
 }  // namespace autofill