Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4674)

Unified Diff: chrome/browser/resources/extensions/pack_extension_overlay.js

Issue 9703039: Extensions: Don't pass the selected unpacked extension path from JS to C++ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/extensions/extensions.js ('k') | chrome/browser/ui/select_file_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/pack_extension_overlay.js
diff --git a/chrome/browser/resources/extensions/pack_extension_overlay.js b/chrome/browser/resources/extensions/pack_extension_overlay.js
index 1bf77635efea6e6e740e128c8995a39aa136e89d..bef1ea36341b550b3b93f301e5ff486c1409c212 100644
--- a/chrome/browser/resources/extensions/pack_extension_overlay.js
+++ b/chrome/browser/resources/extensions/pack_extension_overlay.js
@@ -51,20 +51,20 @@ cr.define('extensions', function() {
},
/**
- * Utility function which asks the C++ to show a platform-specific file
- * select dialog, and fire |callback| with the |filePath| that resulted.
- * |selectType| can be either 'file' or 'folder'. |operation| can be 'load',
- * 'packRoot', or 'pem' which are signals to the C++ to do some
- * operation-specific configuration.
- * @private
- */
+ * Utility function which asks the C++ to show a platform-specific file
+ * select dialog, and fire |callback| with the |filePath| that resulted.
+ * |selectType| can be either 'file' or 'folder'. |operation| can be 'load'
+ * or 'pem' which are signals to the C++ to do some operation-specific
+ * configuration.
+ * @private
+ */
showFileDialog_: function(selectType, operation, callback) {
handleFilePathSelected = function(filePath) {
callback(filePath);
handleFilePathSelected = function() {};
};
- chrome.send('extensionSettingsSelectFilePath', [selectType, operation]);
+ chrome.send('packExtensionSelectFilePath', [selectType, operation]);
},
/**
@@ -84,7 +84,7 @@ cr.define('extensions', function() {
* @private
*/
handleBrowsePrivateKey_: function(e) {
- this.showFileDialog_('file', 'load', function(filePath) {
+ this.showFileDialog_('file', 'pem', function(filePath) {
$('extensionPrivateKey').value = filePath;
});
},
« no previous file with comments | « chrome/browser/resources/extensions/extensions.js ('k') | chrome/browser/ui/select_file_dialog.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698