Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2209)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 9703039: Extensions: Don't pass the selected unpacked extension path from JS to C++ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/pack_extension_overlay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index ac00fc1813f9e8158adb42ee04eb3dd5c748c205..ccea98e52472d85abf5941d0ee836594c8d9aff4 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -67,32 +67,15 @@ cr.define('extensions', function() {
},
/**
- * Utility function which asks the C++ to show a platform-specific file
- * select dialog, and fire |callback| with the |filePath| that resulted.
- * |selectType| can be either 'file' or 'folder'. |operation| can be 'load',
- * 'packRoot', or 'pem' which are signals to the C++ to do some
- * operation-specific configuration.
- * @private
- */
- showFileDialog_: function(selectType, operation, callback) {
- handleFilePathSelected = function(filePath) {
- callback(filePath);
- handleFilePathSelected = function() {};
- };
-
- chrome.send('extensionSettingsSelectFilePath', [selectType, operation]);
- },
-
- /**
* Handles the Load Unpacked Extension button.
* @param {Event} e Change event.
* @private
*/
handleLoadUnpackedExtension_: function(e) {
- this.showFileDialog_('folder', 'pem', function(filePath) {
- chrome.send('extensionSettingsLoad', [String(filePath)]);
- });
+ chrome.send('extensionSettingsLoadUnpackedExtension');
+ // TODO(jhawkins): Refactor metrics support out of options and use it
+ // in extensions.html.
chrome.send('coreOptionsUserMetricsAction',
['Options_LoadUnpackedExtension']);
},
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/pack_extension_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698