Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 969953002: Handle sync changes on the Start Page tiles while context menus are showing. (Closed)

Created:
5 years, 9 months ago by tapted
Modified:
5 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@20150225-AppList-IconImage-NoExtension
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle sync changes on the Start Page tiles while context menus are showing. This handles the case where SearchResultTileItemView::SetSearchResult(SearchResult*) may be called from a nested run loop while its context menu is showing. This cancels the menu (it's for the old item). BUG=462470 TEST=Right-click on a start page app to get its context menu. On another machine (with the same profile), uninstall the app. Context menu should disappear. Chrome shouldn't crash. Committed: https://crrev.com/b7f4866c0a046daf3d836ee058edddf4905d30af Cr-Commit-Position: refs/heads/master@{#318844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/app_list/views/search_result_tile_item_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
calamity
lgtm, thanks for diagnosing and fixing.
5 years, 9 months ago (2015-03-03 00:48:30 UTC) #2
tapted
Thanks Chris! finally got around to verifying the fix works as intended - it does ...
5 years, 9 months ago (2015-03-03 06:11:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969953002/1
5 years, 9 months ago (2015-03-03 06:13:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 06:22:23 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 06:23:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7f4866c0a046daf3d836ee058edddf4905d30af
Cr-Commit-Position: refs/heads/master@{#318844}

Powered by Google App Engine
This is Rietveld 408576698