Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: ui/app_list/views/search_result_tile_item_view.cc

Issue 969953002: Handle sync changes on the Start Page tiles while context menus are showing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150225-AppList-IconImage-NoExtension
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/search_result_tile_item_view.cc
diff --git a/ui/app_list/views/search_result_tile_item_view.cc b/ui/app_list/views/search_result_tile_item_view.cc
index ae3d8b43f3022a8bd4ed45a134f7f909f93c79e4..1823514ad7705001656591dbc88f11c98e4ab94b 100644
--- a/ui/app_list/views/search_result_tile_item_view.cc
+++ b/ui/app_list/views/search_result_tile_item_view.cc
@@ -26,6 +26,10 @@ SearchResultTileItemView::~SearchResultTileItemView() {
}
void SearchResultTileItemView::SetSearchResult(SearchResult* item) {
+ // Handle the case where this may be called from a nested run loop while its
+ // context menu is showing. This cancels the menu (it's for the old item).
+ context_menu_runner_.reset();
+
SetVisible(item != NULL);
SearchResult* old_item = item_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698