chrome/browser/chrome_browser_main_win.cc - Issue 969813005: Unify the Windows Parental Controls Platform Caching

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 969813005: Unify the Windows Parental Controls Platform Caching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Downgrade the check Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main_win.cc

diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc

index 822cd3c6b057a9a45ce7a1fb211f7cfacbeceae8..ff4b6c80de4c254aba690544569f7cea60d71c91 100644

--- a/chrome/browser/chrome_browser_main_win.cc

+++ b/chrome/browser/chrome_browser_main_win.cc

@@ -211,7 +211,8 @@ void ChromeBrowserMainPartsWin::PreMainMessageLoopStart() {

InitializeWindowProcExceptions();

}

- IncognitoModePrefs::InitializePlatformParentalControls();

+ // Initializes and caches the result on Windows.

grt (UTC plus 2) 2015/03/03 20:28:54 nit: // Prime the parental controls cache on Win

robliao 2015/03/03 21:07:12 Done.

+ IncognitoModePrefs::ArePlatformParentalControlsEnabled();

sky 2015/03/03 20:16:53 IMO the old name is clearer. I wouldn't expect a f

robliao 2015/03/03 20:20:34 We stuck with this as a compromise. It's either up

grt (UTC plus 2) 2015/03/03 20:28:54 Seconded. I think it's more clear to have separate

robliao 2015/03/03 21:07:12 Obviously I'm cool with the separation of requirem

}

int ChromeBrowserMainPartsWin::PreCreateThreads() {

« no previous file with comments | « base/win/metro.cc ('k') | chrome/browser/prefs/incognito_mode_prefs.h » ('j') | chrome/browser/prefs/incognito_mode_prefs.cc » ('J')