Unify the Windows Parental Controls Platform Caching

chrome/browser/chrome_browser_main_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_win.h"
 
 #include <windows.h>
 #include <shellapi.h>
 
 #include <algorithm>
@@ skipping 193 matching lines @@
   // installer_util references strings that are normally compiled into
   // setup.exe.  In Chrome, these strings are in the locale files.
   SetupInstallerUtilStrings();
 
   ChromeBrowserMainParts::PreMainMessageLoopStart();
   if (!parameters().ui_task) {
     // Make sure that we know how to handle exceptions from the message loop.
     InitializeWindowProcExceptions();
   }
 
-  IncognitoModePrefs::InitializePlatformParentalControls();
+  // Initializes and caches the result on Windows.

[grt (UTC plus 2), 2015/03/03 20:28:54]

nit:
  // Prime the parental controls cache on Windows.

[robliao, 2015/03/03 21:07:12]

Done.

+  IncognitoModePrefs::ArePlatformParentalControlsEnabled();

[sky, 2015/03/03 20:16:53]

IMO the old name is clearer. I wouldn't expect a function named with 'are' to
have side effects.

[robliao, 2015/03/03 20:20:34]

We stuck with this as a compromise. It's either update all the test cases
(https://codereview.chromium.org/950053002/) or perform the initialization with
the first caller.

[grt (UTC plus 2), 2015/03/03 20:28:54]

Seconded. I think it's more clear to have separate "InitializeThingOnUIThread"
and "QueryThing" methods since their requirements differ.

[robliao, 2015/03/03 21:07:12]

Obviously I'm cool with the separation of requirements since that was the first
delta (https://codereview.chromium.org/950053002/).

The main concern with this approach is that it requires all test cases and
future tests to call this under certain conditions. What are your thoughts on
that?

 }
 
 int ChromeBrowserMainPartsWin::PreCreateThreads() {
   int rv = ChromeBrowserMainParts::PreCreateThreads();
 
   // TODO(viettrungluu): why don't we run this earlier?
   if (!parsed_command_line().HasSwitch(switches::kNoErrorDialogs) &&
       base::win::GetVersion() < base::win::VERSION_XP) {
     chrome::ShowMessageBox(NULL,
         l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
@@ skipping 232 matching lines @@
   if (resource_id)
     return l10n_util::GetStringUTF16(resource_id);
   return base::string16();
 }
 
 // static
 void ChromeBrowserMainPartsWin::SetupInstallerUtilStrings() {
   CR_DEFINE_STATIC_LOCAL(TranslationDelegate, delegate, ());
   installer::SetTranslationDelegate(&delegate);
 }