Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 969763002: Files.app: Prevent shadow animation of grid items on redraw. (Closed)

Created:
5 years, 9 months ago by fukino
Modified:
5 years, 9 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Prevent shadow animation of grid items on redraw. This CL adds the same handling with https://codereview.chromium.org/937343002 BUG=461694 TEST=check the repro steps manually Committed: https://crrev.com/18ab1b4d22d0c3fd622856e766366a8b383e491d Cr-Commit-Position: refs/heads/master@{#318847}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo in the comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table_list.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
fukino
PTAL. Thanks!
5 years, 9 months ago (2015-03-02 12:36:40 UTC) #2
yawano
lgtm with nit. Thank you! https://codereview.chromium.org/969763002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_grid.js File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right): https://codereview.chromium.org/969763002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_grid.js#newcode112 ui/file_manager/file_manager/foreground/js/ui/file_grid.js:112: // from being animated ...
5 years, 9 months ago (2015-03-03 00:17:13 UTC) #3
fukino
Thank you! https://codereview.chromium.org/969763002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_grid.js File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right): https://codereview.chromium.org/969763002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_grid.js#newcode112 ui/file_manager/file_manager/foreground/js/ui/file_grid.js:112: // from being animated unintentinally by redraw. ...
5 years, 9 months ago (2015-03-03 06:41:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969763002/20001
5 years, 9 months ago (2015-03-03 06:42:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 07:24:03 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 07:24:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18ab1b4d22d0c3fd622856e766366a8b383e491d
Cr-Commit-Position: refs/heads/master@{#318847}

Powered by Google App Engine
This is Rietveld 408576698