Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 937343002: Files.app: Prevent flicker of checkmarks on selected items. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Prevent flicker of checkmarks on selected items. BUG=459101, 454730 TEST=checked the repro step of both bugs manually Committed: https://crrev.com/32a384ce8acf4a998983487fe1ce7a1a1bab0532 Cr-Commit-Position: refs/heads/master@{#317221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_table_list.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
PTAL. Thanks!
5 years, 10 months ago (2015-02-20 01:25:40 UTC) #2
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-20 01:49:15 UTC) #3
fukino
On 2015/02/20 01:49:15, yawano wrote: > lgtm. Thank you! Thanks!
5 years, 10 months ago (2015-02-20 01:49:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937343002/1
5 years, 10 months ago (2015-02-20 01:50:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 02:22:12 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 02:23:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32a384ce8acf4a998983487fe1ce7a1a1bab0532
Cr-Commit-Position: refs/heads/master@{#317221}

Powered by Google App Engine
This is Rietveld 408576698