Telemetry: Catch exceptions.Error instead of AppCrashException.

Telemetry: Catch exceptions.Error instead of AppCrashException.

Each location that catches AppCrashException does not actually want to know if
the app crashed. Rather, the code wants to know if there was an error
performing an operation. I've updated teh code to catch the more general
Exception.

BUG=460625
Committed: https://crrev.com/38186fc4816e4e000f5e4789d7b4f9d09ce61c04
Cr-Commit-Position: refs/heads/master@{#319157}

[erikchen, 2015-02-28 00:24:20]

erikchen@chromium.org changed reviewers:
+ nednguyen@google.com

[erikchen, 2015-02-28 00:24:20]

nednguyen: Please review.

[nednguyen, 2015-03-04 00:19:48]

nednguyen@google.com changed reviewers:
+ achuith@chromium.org

[achuithb, 2015-03-04 00:31:15]

https://codereview.chromium.org/969503002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py (right):

https://codereview.chromium.org/969503002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py:66:
devtools_http.DevToolsClientConnectionError):
DevToolsClientConnectionError does not inherit from Error, is that right? Could
we make it so that it does?

[erikchen, 2015-03-04 01:14:16]

https://codereview.chromium.org/969503002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py (right):

https://codereview.chromium.org/969503002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py:66:
devtools_http.DevToolsClientConnectionError):
On 2015/03/04 00:31:15, achuithb wrote:
> DevToolsClientConnectionError does not inherit from Error, is that right?
Could
> we make it so that it does?

Yes. I will do that in a followup CL.

[achuithb, 2015-03-04 21:28:04]

On 2015/03/04 01:14:16, erikchen wrote:
>
https://codereview.chromium.org/969503002/diff/20001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py (right):
> 
>
https://codereview.chromium.org/969503002/diff/20001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py:66:
> devtools_http.DevToolsClientConnectionError):
> On 2015/03/04 00:31:15, achuithb wrote:
> > DevToolsClientConnectionError does not inherit from Error, is that right?
> Could
> > we make it so that it does?
> 
> Yes. I will do that in a followup CL.

Ok, seems like you'll have to revisit this a second time after you do that.

lgtm.

[erikchen, 2015-03-04 22:13:49]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-03-04 22:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969503002/20001

[commit-bot: I haz the power, 2015-03-04 23:18:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-04 23:19:08]

Patchset 2 (id:??) landed as
https://crrev.com/38186fc4816e4e000f5e4789d7b4f9d09ce61c04
Cr-Commit-Position: refs/heads/master@{#319157}