tools/telemetry/telemetry/page/shared_page_state.py - Issue 969503002: Telemetry: Catch exceptions.Error instead of AppCrashException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 969503002: Telemetry: Catch exceptions.Error instead of AppCrashException. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry_make_new_exceptions4

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py ('K') | « tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py ('k') | tools/telemetry/telemetry/user_story/user_story_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/shared_page_state.py

diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py

index 4bf56ad0ca20706d12bb9d71649b3ae08bfaf1b8..4a9c4d7925785b6213d6f5e56a97bcbc58965028 100644

--- a/tools/telemetry/telemetry/page/shared_page_state.py

+++ b/tools/telemetry/telemetry/page/shared_page_state.py

@@ -240,11 +240,11 @@ class SharedPageState(shared_user_story_state.SharedUserStoryState):

self._PreparePage()

self._ImplicitPageNavigation()

self._test.RunPage(self._current_page, self._current_tab, results)

- except exceptions.AppCrashException:

+ except exceptions.Error:

if self._test.is_multi_tab_test:

# Avoid trying to recover from an unknown multi-tab state.

exception_formatter.PrintFormattedException(

- msg='AppCrashException during multi tab test:')

+ msg='Telemetry Error during multi tab test:')

raise page_test.MultiTabTestAppCrashError

raise