Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 969223002: Autofill wallet -- handle several classes of error in unmasking prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: local Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index ca6399ad959b01df66b70a96737c2645c5d57a23..20121fc6410def11ac0c61cb2b0d51b134c00977 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -778,8 +778,10 @@ IdentityProvider* AutofillManager::GetIdentityProvider() {
return client()->GetIdentityProvider();
}
-void AutofillManager::OnDidGetRealPan(const std::string& real_pan) {
+void AutofillManager::OnDidGetRealPan(AutofillClient::GetRealPanResult result,
+ const std::string& real_pan) {
if (!real_pan.empty()) {
+ DCHECK_EQ(AutofillClient::SUCCESS, result);
credit_card_form_event_logger_->OnDidFillSuggestion(unmasking_card_);
unmasking_card_.set_record_type(CreditCard::FULL_SERVER_CARD);
unmasking_card_.SetNumber(base::UTF8ToUTF16(real_pan));
@@ -790,7 +792,7 @@ void AutofillManager::OnDidGetRealPan(const std::string& real_pan) {
unmasking_card_);
}
- client()->OnUnmaskVerificationResult(!real_pan.empty());
+ client()->OnUnmaskVerificationResult(result);
}
void AutofillManager::OnDidEndTextFieldEditing() {
« no previous file with comments | « components/autofill/core/browser/autofill_manager.h ('k') | components/autofill/core/browser/autofill_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698